feature(node): ERC20 and ETH support #2325

micahriggan · 2019-08-09T19:39:44Z

Can now sync ETH and get wallet history for ERC20 tokens

Refactoring currency support into a module system. This allows the creation of 3rd party modules, and arbitrary currency support without forking.

ETH Syncing via

      "ETH": {
        "mainnet": {
          "chainSource": "p2p",
          "trustedPeers": [
            {
              "host": "127.0.0.1",
              "port": 30303
            }
          ],
          "provider": {
            "host": "127.0.0.1",
            "protocol":"ws",
            "port": 8546
          }
        }
      }

Testing

I've been testing with this local development node

alias parity-dev="/Users/micah/blockchains/eth/parity2.4.2 --config dev --base-path '/Users/micah/blockchains/eth/dev' --db-compaction ssd --cache-size 8192 --jsonrpc-cors=all --ws-origins=all --ws-apis=all"

and this private key
0x4d5db4107d237df6a3d58ee5f70ae63d73d7658d4026f2eefd2f204c81682cb7 imported into metamask

Can now sync ETH and get wallet history for ERC20 tokens

packages/bitcore-node/src/modules/ethereum/api/eth-routes.ts

packages/bitcore-node/src/modules/ethereum/models/transaction.ts

…odule-squashed

ETH blocks were using the BTC transforms, fixed that

nitsujlangston · 2019-08-23T14:26:17Z

packages/bitcore-node/src/routes/api/wallet.ts

@@ -115,7 +115,7 @@ router.get('/:pubKey/addresses/missing', authenticate, async (req: Authenticated
      pubKey,
      stream: res
    };
-    return ChainStateProvider.streamMissingWalletAddresses(payload);
+    return await ChainStateProvider.streamMissingWalletAddresses(payload);


if this is streaming why does it await?

nitsujlangston · 2019-08-23T14:26:33Z

packages/bitcore-node/src/routes/api/wallet.ts

@@ -134,7 +134,7 @@ router.get('/:pubKey/addresses', authenticate, async (req: AuthenticatedRequest,
      req,
      res
    };
-    return ChainStateProvider.streamWalletAddresses(payload);
+    return await ChainStateProvider.streamWalletAddresses(payload);


if this is streaming why does it await?

nitsujlangston · 2019-08-23T14:26:39Z

packages/bitcore-node/src/routes/api/wallet.ts

@@ -188,7 +188,7 @@ router.post('/:pubKey', authenticate, async (req: AuthenticatedRequest, res) =>
 router.get('/:pubKey/transactions', authenticate, async (req: AuthenticatedRequest, res) => {
  let { chain, network } = req.params;
  try {
-    return ChainStateProvider.streamWalletTransactions({
+    return await ChainStateProvider.streamWalletTransactions({


if this is streaming why does it await?

So interesting thing I learned. If there's a throw inside of an async method that streams, then you'll get an unhandled promise rejection if you don't await that method.

micahriggan · 2019-08-23T14:46:50Z

packages/bitcore-node/src/modules/ethereum/models/transaction.ts

+
+  onConnect() {
+    super.onConnect();
+    this.collection.createIndex({ chain: 1, network: 1, to: 1 }, { background: true });


…odule-squashed

justinkook · 2019-08-26T14:11:16Z

packages/bitcore-node/src/modules/ethereum/models/transaction.ts

+    if (!initialSyncComplete) {
+      return;
+    }
+    let prunedTxs = {};


fix pruneTxs always empty object

…odule-squashed

micahriggan force-pushed the feature/eth-module-squashed branch 2 times, most recently from e6e485b to 5f5eae6 Compare August 12, 2019 16:44

matiu mentioned this pull request Aug 12, 2019

Eth #2281

Merged

feature(node): eRC20 and ETH support

d08ea9d

Can now sync ETH and get wallet history for ERC20 tokens

micahriggan force-pushed the feature/eth-module-squashed branch from 5f5eae6 to d08ea9d Compare August 13, 2019 14:45

Need to call transfer, not approve

b104437

justinkook suggested changes Aug 15, 2019

View reviewed changes

packages/bitcore-node/src/modules/ethereum/api/eth-routes.ts Outdated Show resolved Hide resolved

packages/bitcore-node/src/modules/ethereum/api/eth-routes.ts Outdated Show resolved Hide resolved

justinkook reviewed Aug 16, 2019

View reviewed changes

packages/bitcore-node/src/modules/ethereum/models/transaction.ts Outdated Show resolved Hide resolved

micahriggan added 6 commits August 20, 2019 14:31

Merge branch 'master' of github.com:bitpay/bitcore into feature/eth-m…

0a3b957

…odule-squashed

Moving some methods out of route and into ETH CSP

518b467

Centralizing the abi-decoder usage

f6cc2e6

Better handling of connection issues with ETH

b7a5cf2

feature(node): eTH blocks use the correct transform

24a7d60

ETH blocks were using the BTC transforms, fixed that

Adding gasLimit and gasUsed to transform

c8797ea

nitsujlangston reviewed Aug 23, 2019

View reviewed changes

micahriggan commented Aug 23, 2019

View reviewed changes

micahriggan added 3 commits August 23, 2019 11:09

Merge branch 'master' of github.com:bitpay/bitcore into feature/eth-m…

44ab175

…odule-squashed

Sparse ETH index

3467da0

Merge branch 'master' of github.com:bitpay/bitcore into feature/eth-m…

8788277

…odule-squashed

This was referenced Aug 23, 2019

Feature(BWS) - ETH #2345

Closed

Feature(BWC) - ETH #2346

Closed

micahriggan force-pushed the feature/eth-module-squashed branch 3 times, most recently from 002b129 to e12cc24 Compare August 23, 2019 20:25

Updating package-lock for web3.

a031a9b

micahriggan force-pushed the feature/eth-module-squashed branch from e12cc24 to a031a9b Compare August 23, 2019 20:37

Normalizing typescript version across packages

e9bec10

justinkook reviewed Aug 26, 2019

View reviewed changes

micahriggan force-pushed the feature/eth-module-squashed branch from 2e33d95 to e9bec10 Compare August 26, 2019 14:30

Use npm 6.4.1

e0b822e

micahriggan added 4 commits September 11, 2019 16:32

Removing console.log

9fd6be9

Fixing reorg issue

dcb5a4a

Updating wallet import function

a8d9cc7

Renaming to updateWallet and making updateWallet a void method

478ea8d

micahriggan force-pushed the feature/eth-module-squashed branch from 3c73bb3 to 478ea8d Compare September 12, 2019 21:19

micahriggan added 8 commits September 16, 2019 11:29

Using static web3

a79945f

Try to detect web3 connection issue

89acb77

Trying to handle the web3 connections better

b6ce614

Cleaning up fee calculation to help with slow calls

1b24669

Passing arguments so we can filter to and from

69d3d87

Adding data to tx response

c5d82ab

Fixing valueOrDefault issue, adding more things to eth api transform

7daa1af

Rewriting erc20 transaction history

a7a2639

micahriggan force-pushed the feature/eth-module-squashed branch 2 times, most recently from 1002638 to f8dac47 Compare September 16, 2019 19:46

Adding wallet hint for erc20

38081bf

micahriggan force-pushed the feature/eth-module-squashed branch from f8dac47 to 38081bf Compare September 16, 2019 19:46

micahriggan added 12 commits September 16, 2019 17:24

Adding index for erc20 value

6ab309d

Ensuring index will hit

68e8f71

Adding query and logging

d9d8226

Require abiType exists

7a58021

fixing query bug

32dfe31

addresses on token decodes are lowercase

7eae8fc

Callback null first

0f0c7e8

Remove transform stream

feb4fb6

Push null

007de2a

Checksum address the to address

88ceb2b

Merge branch 'master' of github.com:bitpay/bitcore into feature/eth-m…

4855b4d

…odule-squashed

Updating package-lock

58b1e7a

matiu merged commit e825d60 into bitpay:master Sep 17, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature(node): ERC20 and ETH support #2325

feature(node): ERC20 and ETH support #2325

micahriggan commented Aug 9, 2019 •

edited

Loading

nitsujlangston Aug 23, 2019

micahriggan Aug 30, 2019

nitsujlangston Aug 23, 2019

nitsujlangston Aug 23, 2019

micahriggan Aug 23, 2019

micahriggan Aug 23, 2019

justinkook Aug 26, 2019

micahriggan Aug 26, 2019

feature(node): ERC20 and ETH support #2325

feature(node): ERC20 and ETH support #2325

Conversation

micahriggan commented Aug 9, 2019 • edited Loading

Testing

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

micahriggan commented Aug 9, 2019 •

edited

Loading