-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added scipy to requirements.txt #525
Conversation
Added scipy to requirements.txt as it is used but not added to requirements
+1 This breaks the conditional importing of try:
import bitsandbytes
has_bitsandbytes = True
except ImportError:
bitsandbytes = None # type: ignore
has_bitsandbytes = False
EDIT: According to the official docs, the requirement should also be added to |
I think that the dependency should also be added to the |
@TimDettmers |
Should be a quick merge in case this got forgotten 😅 |
@TimDettmers is this ok to merge? 8a20cd8 is indeed not enough. Anyone installing bitsandbytes through pip e.g. |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. |
This still needs to be addressed. Easy fix, should be merged |
Sorry for the delay on this. Thanks for contributing this fix! |
Added scipy to requirements.txt as it is used but not added to requirements