Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove shim for bitsandbytes versions that don't support the device parameter #228

Merged
merged 4 commits into from
Jul 12, 2023

Conversation

shadeMe
Copy link
Collaborator

@shadeMe shadeMe commented Jul 11, 2023

Description

Also, add an extra check to ensure that bitsandbytes' unspecified installation dependency on scipy is satisfied (cf bitsandbytes-foundation/bitsandbytes#525).

Types of change

Fix

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@danieldk danieldk merged commit 9f7a665 into explosion:main Jul 12, 2023
@shadeMe shadeMe deleted the fix/bnb-scipy-scaffold branch July 12, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants