Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-12400] Add private key regeneration SDK methods #6

Merged
merged 7 commits into from
Dec 11, 2024

Conversation

Thomas-Avery
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-12400

📔 Objective

Add shared methods to enable private key regeneration in clients.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Thomas-Avery Thomas-Avery self-assigned this Oct 22, 2024
Copy link
Contributor

github-actions bot commented Oct 22, 2024

Logo
Checkmarx One – Scan Summary & Detailsdf21609f-22eb-482e-9cfc-a0b9f3e86351

No New Or Fixed Issues Found

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 82.23684% with 27 lines in your changes missing coverage. Please review.

Project coverage is 64.06%. Comparing base (19c56fb) to head (9866b94).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/bitwarden-wasm-internal/src/crypto.rs 0.00% 12 Missing ⚠️
crates/bitwarden-core/src/mobile/client_crypto.rs 0.00% 9 Missing ⚠️
crates/bitwarden-core/src/mobile/crypto.rs 95.41% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
+ Coverage   63.85%   64.06%   +0.21%     
==========================================
  Files         186      186              
  Lines       12905    13057     +152     
==========================================
+ Hits         8240     8365     +125     
- Misses       4665     4692      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dani-garcia
dani-garcia previously approved these changes Oct 22, 2024
Copy link
Member

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice LGTM!

quexten
quexten previously approved these changes Oct 22, 2024
@Thomas-Avery Thomas-Avery dismissed stale reviews from dani-garcia and quexten via 3ac3cf6 November 13, 2024 23:34
@Thomas-Avery Thomas-Avery merged commit 28c7e29 into main Dec 11, 2024
39 checks passed
@Thomas-Avery Thomas-Avery deleted the km/pm-12400/private-key-regen branch December 11, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants