Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SM-1096: Refactor state_file_path and others to state_path #587

Closed
wants to merge 2 commits into from

Conversation

coltonhurst
Copy link
Member

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Code changes

  • file.ext: Description of what was changed and why

Before you submit

  • Please add unit tests where it makes sense to do so

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (69a5d7b) 53.77% compared to head (75db990) 53.77%.
Report is 3 commits behind head on main.

Files Patch % Lines
crates/bitwarden/src/auth/login/access_token.rs 37.50% 5 Missing ⚠️
crates/bitwarden/src/auth/renew.rs 0.00% 4 Missing ⚠️
crates/bitwarden/src/secrets_manager/state.rs 0.00% 4 Missing ⚠️
crates/bws/src/main.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #587   +/-   ##
=======================================
  Coverage   53.77%   53.77%           
=======================================
  Files         165      165           
  Lines        8878     8878           
=======================================
  Hits         4774     4774           
  Misses       4104     4104           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bitwarden-bot
Copy link

bitwarden-bot commented Feb 6, 2024

Logo
Checkmarx One – Scan Summary & Details0676a9c3-a670-4467-a670-931ef0801aba

No New Or Fixed Issues Found

@coltonhurst
Copy link
Member Author

coltonhurst commented Jul 10, 2024

Closing in favor of new sm/sm-1096 PR: #895

@coltonhurst coltonhurst deleted the sm/sm-1096 branch July 10, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants