SM-1092: Add SM State to the Ruby SDK Wrapper #565
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #565 +/- ##
=======================================
Coverage ? 57.76%
=======================================
Files ? 168
Lines ? 9912
Branches ? 0
=======================================
Hits ? 5726
Misses ? 4186
Partials ? 0 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
Thomas-Avery
added a commit
that referenced
this pull request
Feb 21, 2024
## Type of change <!-- (mark with an `X`) --> ``` - [ ] Bug fix - [ ] New feature development - [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ``` ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Rename the ruby sdk to `bitwarden-sdk-secrets` to denote it's the secrets manager SDK. Updates the Also includes #565 since it won't run without that change. ## Before you submit - Please add **unit tests** where it makes sense to do so --------- Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>
|
Closing as #618 included this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Add the ability to easily use SM state in Ruby to the
bitwarden-sdkgem.Code changes
access_token_loginaccess_token_loginBefore you submit