Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ruby SDK to bitwarden-sdk-secrets #618

Merged
merged 7 commits into from
Feb 21, 2024
Merged

Rename ruby SDK to bitwarden-sdk-secrets #618

merged 7 commits into from
Feb 21, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Feb 19, 2024

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Rename the ruby sdk to bitwarden-sdk-secrets to denote it's the secrets manager SDK. Updates the

Also includes #565 since it won't run without that change.

Before you submit

  • Please add unit tests where it makes sense to do so

@Hinton Hinton requested a review from a team as a code owner February 19, 2024 10:02
@Hinton Hinton requested a review from a team February 19, 2024 10:06
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ff94313) 59.40% compared to head (59816df) 59.40%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #618   +/-   ##
=======================================
  Coverage   59.40%   59.40%           
=======================================
  Files         171      171           
  Lines       10345    10345           
=======================================
  Hits         6145     6145           
  Misses       4200     4200           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bitwarden-bot
Copy link

bitwarden-bot commented Feb 19, 2024

Logo
Checkmarx One – Scan Summary & Detailsc7dbfe06-211a-4404-8540-248526daee86

No New Or Fixed Issues Found

Copy link
Contributor

@Thomas-Avery Thomas-Avery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Thomas-Avery Thomas-Avery merged commit 0366e86 into main Feb 21, 2024
61 checks passed
@Thomas-Avery Thomas-Avery deleted the ps/ruby-rename branch February 21, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants