-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SM-1153] Part 2 Secrets sync | Expose in SM SDK #678
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #678 +/- ##
==========================================
- Coverage 58.77% 58.56% -0.22%
==========================================
Files 177 178 +1
Lines 11501 11543 +42
==========================================
Hits 6760 6760
- Misses 4741 4783 +42 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, just needs some changes around the use of the MissingFields error, which has been changed very recently to include more information on which field is actually missing. I've included a suggestion on how to apply that change.
No New Or Fixed Issues Found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @Thomas-Avery
The base branch was changed.
Type of change
Objective
The purpose of this PR is to expose the ability to preform secrets syncs via the Secrets Manager SDK.
Requires API bindings in #674
This should not be merged into main prior to:
Code changes
crates/bitwarden/src/secrets_manager/client_secrets.rs:
Add the
sync
method to the client secrets.crates/bitwarden/src/secrets_manager/secrets/mod.rs:
Expose
sync
SecretsSyncRequest
, andSecretsSyncResponse
crates/bitwarden/src/secrets_manager/secrets/sync.rs:
Implement
sync
SecretsSyncRequest
, andSecretsSyncResponse
Before you submit