[SM-1150] Add secret sync endpoint #3906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3906 +/- ##
==========================================
+ Coverage 37.86% 38.01% +0.14%
==========================================
Files 1192 1195 +3
Lines 57988 58134 +146
Branches 5549 5567 +18
==========================================
+ Hits 21960 22102 +142
+ Misses 34995 34993 -2
- Partials 1033 1039 +6 ☔ View full report in Codecov by Sentry. |
|
New Issues
Fixed Issues
|
coltonhurst
previously approved these changes
Apr 17, 2024
There was a problem hiding this comment.
@Thomas-Avery this looks good, thanks for the hard work on this!
Nice uses of ExecuteDeleteAsync and using declarations 😄
coltonhurst
reviewed
Apr 17, 2024
test/Api.Test/SecretsManager/Controllers/SecretsControllerTests.cs
Outdated
Show resolved
Hide resolved
coltonhurst
approved these changes
Apr 17, 2024
Thomas-Avery
added a commit
to bitwarden/sdk-sm
that referenced
this pull request
May 15, 2024
## Type of change <!-- (mark with an `X`) --> ``` - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ``` ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Expose the new secrets sync endpoint. Server PR bitwarden/server#3906 ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> ran the command `./support/build-api.sh` ## Before you submit - Please add **unit tests** where it makes sense to do so
Thomas-Avery
added a commit
to bitwarden/sdk-sm
that referenced
this pull request
May 15, 2024
## Type of change <!-- (mark with an `X`) --> ``` - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ``` ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> The purpose of this PR is to expose the ability to preform secrets syncs via the Secrets Manager SDK. Requires API bindings in #674 This should not be merged into main prior to: - The server PR bitwarden/server#3906 being merged and released - The API bindings PR #674 being merged into main ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> - **crates/bitwarden/src/secrets_manager/client_secrets.rs:** Add the `sync` method to the client secrets. - **crates/bitwarden/src/secrets_manager/secrets/mod.rs:** Expose `sync` `SecretsSyncRequest`, and `SecretsSyncResponse` - **crates/bitwarden/src/secrets_manager/secrets/sync.rs:** Implement `sync` `SecretsSyncRequest`, and `SecretsSyncResponse` ## Before you submit - Please add **unit tests** where it makes sense to do so
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
The purpose of this PR is to add a new secrets sync endpoint for Secrets Manager.
This also includes repository code updates to update a service account's
RevisionDatewhen an event occurs that would require a new secrets sync for the given service account.Code changes
bitwarden_license/src/Commercial.Core/SecretsManager/Queries/Secrets/SecretsSyncQuery.cs:
src/Core/SecretsManager/Queries/Secrets/Interfaces/ISecretsSyncQuery.cs:
A new query for determining if a secrets sync is needed and if so returns all secrets the service account has access to.
bitwarden_license/src/Commercial.Core/SecretsManager/SecretsManagerCollectionExtensions.cs:
Adding the new query into DI.
bitwarden_license/src/Commercial.Infrastructure.EntityFramework/SecretsManager/Repositories/AccessPolicyRepository.cs:
Update affected service account's revision date on creation and deletion of access policies.
bitwarden_license/src/Commercial.Infrastructure.EntityFramework/SecretsManager/Repositories/ProjectRepository.cs:
Update affected service account's revision date on deletion of a project.
bitwarden_license/src/Commercial.Infrastructure.EntityFramework/SecretsManager/Repositories/SecretRepository.cs:
src/Core/SecretsManager/Repositories/ISecretRepository.cs:
src/Core/SecretsManager/Repositories/Noop/NoopSecretRepository.cs:
Update affected service account's revision date on secret creation, update, soft delete, restore, and hard delete
Rename
GetManyByOrganizationIdInTrashAsync,GetManyByProjectIdAsync, andGetManyByOrganizationIdAsyncto make it clear they returnSecretPermissionDetailsnot just secret entities.bitwarden_license/test/Commercial.Core.Test/SecretsManager/Queries/Secrets/SecretsSyncQueryTests.cs:
Unit tests.
src/Api/SecretsManager/Controllers/SecretsController.cs:
Add new endpoint
Secret repository renames
src/Api/SecretsManager/Controllers/SecretsManagerPortingController.cs:
Secret repository renames
src/Api/SecretsManager/Controllers/SecretsTrashController.cs:
Secret repository renames
src/Api/SecretsManager/Models/Response/SecretsSyncResponseModel.cs:
Response model for new secrets sync endpoint.
src/Core/SecretsManager/Models/Data/SecretsSyncRequest.cs:
Data model for all the properties required for a
SecretsSyncQuery.test/Api.IntegrationTest/SecretsManager/Controllers/SecretsControllerTests.cs:
Integration tests
test/Api.Test/SecretsManager/Controllers/SecretsControllerTests.cs:
Unit tests
Before you submit
dotnet format --verify-no-changes) (required)