Supported shader barycentric coords on OpenGL, Vulkan and Metal #3090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Looks good! I'm just going to wait for glslang and SPIRV-Cross to accept it. |
|
You shouldn't be using merge into this branch, rather rebase, so that your changes always appear as the top. |
I can? It's good to know for next time, thanks! :) |
|
You can even fix this branch by removing undesired merges so that only new changes appear, and then force pushing it. |
jay3d
force-pushed
the
barycentrics
branch
2 times, most recently
from
0859c47
to
ba661ef
Compare
jay3d
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fragment shader barycentric coords support following this spec: https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VK_KHR_fragment_shader_barycentric.html
I have modified some 3rdparty sources for this to work and I have made PRs of those to their respected repositories:
KhronosGroup/glslang#3198
KhronosGroup/SPIRV-Cross#2137
So when the above gets approved and merged, it will be already here.