Fix the code example editor service to use the major version of Angular packages to determine SemVer range #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ar packages to determine SemVer range
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
| @@ -28,7 +28,7 @@ export class SkyDocsCodeExamplesEditorService { | |||
| } | |||
|
|
|||
| #getPayload(codeExample: SkyDocsCodeExample): StackBlitzProject { | |||
| const angularVersion = `^${ANGULAR_VERSION.full}`; | |||
| const angularVersion = `^${ANGULAR_VERSION.major}`; | |||
There was a problem hiding this comment.
@angular/core and @angular/cli have different latest versions; we'll pull in the major version instead.
johnhwhite
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.