Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the code example editor service to use the major version of Angular packages to determine SemVer range #266

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Fix the code example editor service to use the major version of Angular packages to determine SemVer range #266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e10363
Fix the code example editor service to use the major version of Angul…
Blackbaud-SteveBrush Sep 21, 2023
b8eebef
update changelog
Blackbaud-SteveBrush Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## 9.1.3 (2023-09-21)

- Fixed the code example editor service to use the major version of Angular packages to determine SemVer range. [#266](https://github.com/blackbaud/skyux-docs-tools/pull/266)

## 9.1.2 (2023-09-21)

- Fixed the code example editor service to use the latest supported version of `@skyux/icons`, `@skyux/core`, and `@angular/core`. [#264](https://github.com/blackbaud/skyux-docs-tools/pull/264)
Expand Down
2 changes: 1 addition & 1 deletion projects/docs-tools/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@skyux/docs-tools",
"version": "9.1.2",
"version": "9.1.3",
"peerDependencies": {
"@angular/common": "^16.2.5",
"@angular/core": "^16.2.5",
Expand Down
2 changes: 1 addition & 1 deletion projects/docs-tools/src/modules/code-examples/code-examples-editor.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ describe('Code examples editor service', () => {

service.launchEditor(codeExample);

const angularVersion = `^${ANGULAR_VERSION.full}`;
const angularVersion = `^${ANGULAR_VERSION.major}`;
const skyuxVersion = `^${SKY_UX_VERSION.full}`;

expect(stackblitzSpy.calls.mostRecent().args[0].dependencies).toEqual({
Expand Down
2 changes: 1 addition & 1 deletion projects/docs-tools/src/modules/code-examples/code-examples-editor.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export class SkyDocsCodeExamplesEditorService {
}

#getPayload(codeExample: SkyDocsCodeExample): StackBlitzProject {
const angularVersion = `^${ANGULAR_VERSION.full}`;
const angularVersion = `^${ANGULAR_VERSION.major}`;
Copy link
Member Author

@Blackbaud-SteveBrush Blackbaud-SteveBrush Sep 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angular/core and @angular/cli have different latest versions; we'll pull in the major version instead.

const skyuxVersion = `^${SKY_UX_VERSION.full}`;

const defaultDependencies: SkyDocsCodeExampleModuleDependencies = {
Expand Down
Loading