Always show recording link even if recordings are currently disabled #2787
Conversation
|
Can you test this in the event that the user never enabled record there are no recordings? Historically that caused the recordings page to go into a crazy crash loop. |
Sure I'll test that! I did test with events but no recording and it worked, just so you know. |
|
Events are just another way to save recordings. I'm talking about situations where there are no recordings at all for a camera. |
|
@blakeblackshear Right, makes sense, my bad. I tested this situation by doing a clean run with an IP camera that has recordings disabled and opening the recordings link. This is what it showed:
|
…nto always-show-recording-link
|
Looks like you broke a unit test. This is such a small change, I will include it in 0.10.0. |
|
@blakeblackshear Thanks! Test should be passing now |
…2787) * Always show recording link even if recordings are currently disabled * Fix test to consider all cameras to have recording link
Fix for #2610
I keep recordings on for both of my cameras, but I have one that I only record when my dog is left at home. It is helpful to always be able to view those recordings even if they are currently disabled. I'm thinking perhaps it may be possible to check if that camera currently has any recording clips but that might also be an expensive call.