Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always show recording link even if recordings are currently disabled #2787

Merged
merged 4 commits into from
Feb 12, 2022
Merged

Always show recording link even if recordings are currently disabled #2787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
08f58ce
Always show recording link even if recordings are currently disabled
NickM-27 Feb 10, 2022
a0b7fd3
Merge branch 'release-0.10.0' of github.com:blakeblackshear/frigate i…
NickM-27 Feb 11, 2022
994f74b
Fix test to consider all cameras to have recording link
NickM-27 Feb 12, 2022
81437df
Merge branch 'release-0.10.0' of github.com:blakeblackshear/frigate i…
NickM-27 Feb 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions web/src/routes/Cameras.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,8 @@ function Camera({ name, conf }) {
const { payload: snapshotValue, send: sendSnapshots } = useSnapshotsState(name);
const href = `/cameras/${name}`;
const buttons = useMemo(() => {
const result = [{ name: 'Events', href: `/events?camera=${name}` }];
if (conf.record.enabled) {
result.push({ name: 'Recordings', href: `/recording/${name}` });
}
return result;
}, [name, conf.record.enabled]);
return [{ name: 'Events', href: `/events?camera=${name}` }, { name: 'Recordings', href: `/recording/${name}` }];
}, [name]);
const icons = useMemo(
() => [
{
Expand Down
2 changes: 1 addition & 1 deletion web/src/routes/__tests__/Cameras.test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ describe('Cameras Route', () => {

expect(screen.queryByLabelText('Loading…')).not.toBeInTheDocument();

expect(screen.queryAllByText('Recordings')).toHaveLength(1);
expect(screen.queryAllByText('Recordings')).toHaveLength(2);
});

test('buttons toggle detect, clips, and snapshots', async () => {
Expand Down