Update to tslint v4.0.1 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mdurling
commented
Nov 21, 2016
mdurling
commented
- Remove no-unreachable
- Remove no-unused-variable
- Update package.json
- Regenerate test data
* Remove no-unreachable * Remove no-unused-variable * Update package.json * Regenerate test data
|
This PR contains all of the necessary package update, rule changes, and testcase updates. |
|
I am not sure why the Travis CI check is failing. It is passing when I run the tests locally. |
|
Probably waiting on buzinas/tslint-eslint-rules#138. |
|
@blakeembrey Let me know if you need me to do anything else with this PR. |
|
v3.0.0 has been released on npm. Let me know if you guys encounter any issues. |
|
@blakeembrey PR #14 has been updated to include tslint-eslint-rules@3.0.0 |
|
@mdurling you beat me to it. 🌷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.