This repository has been archived by the owner on Feb 21, 2022. It is now read-only.
Tslint 4.0 #138
Merged
Tslint 4.0 #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
November 19, 2016 16:39
Currently these errors are could be left out by Travis CI.
This has been deprecated on tslint 4.0. They recommend we turn on noUnusedParameters and noUnusedLocals on the typescript configuration.
See https://palantir.github.io/tslint/2016/11/17/new-for-4.0.html. Overall we had to remove deprecated rules from our tslint.json file and change our import statements. The helper file had major changes due to their new API. All tests are passing right now.
This was a core rule from TSLint and it has deprecated since typescript handles it.
The rule tester will replace the helper file in the tests. A few more modifications need to be done before the release. For instance I’m not happy with the `IFailure` interface name. This needs to be changed. All the tests for the ter-max-len rule have been updated to make use of the RuleTester.
It now supports tslint 4.0, the tests should be passing now. I had to turn off the max-line-length rule since I violate it on the readme. I will try to run a check on our files with our own custom rules.
In this case I have turned on the `ter-max-len` rule on so that we may stop the linter from warning us when a line exceeds 180 due to a url encounter. Travis should pass now I believe. Lets see.
Tried to turn on object-curly-spacing but there are way too many errors on the ter-indent tests. The tests will be split into groups soon so I will turn on the rule once this is done.
All the tests need are: RuleTester, Failure, Position, and decent from the ruleTester module.
using the ruleTesters to simplify the tests.
|
@buzinas @blakeembrey All tests are passing again. Any of you have some time to do a quick code review? I'd like to release today so that I may start using tslint 4.0 and this project together. |
jmlopez-rod
commented
Nov 21, 2016
| @@ -0,0 +1,14 @@ | |||
| { | |||
There was a problem hiding this comment.
@buzinas I noticed that there is a file called eslint_tslint.json with a list of the rules in the project. Where those meant to be the preferences for the source code in this project? I tried them but it gave a lot of errors so I'll be adding some rules here and there as I see them fit. For now I started with the obvious ones. Is it safe to delete eslint_tslint.json?
|
I think it looks good, thanks for your all your work! |
|
Awesome, i'll go ahead and release this sometime during my lunch break. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not yet done. The CI will fail since
gulp-tslinthas not been released with the tslint update yet. It may happen sometime tomorrow.For now all the changes included here make the tests pass if we skip the linting process:
I'll do another round of updates once this issue is resolved: panuhorsmalahti/gulp-tslint#90