Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix protected recordings #1083

Merged

Conversation

Ithanil
Copy link
Contributor

@Ithanil Ithanil commented Jun 13, 2024

This PR fixes the protected recordings feature for all formats.

Description

Protected recordings have been broken, i.e. unprotected paths were served by nginx, since at least SL v1.5. This has been reported in several issues.
The changes to nginx locations for presentation and video formats were originally proposed by @schrd in #983 (comment)

Testing Steps

  1. Generate a recording with all formats
  2. transfer them to SL with protected recordings enabled
  3. access them by clicking a format button in GL3
  4. copy the (unprotected) recording URL from your browser into a different browser or private window
  5. verify that you can't access the recording without token or cookie

only the screenshare format is untested (of which I'm not sure if it actually works in any capacity at all), but it should behave just like the video format
EDIT: Screenshare format tested and works as well

Fixed issues

#983
#1008
#1046

I think it also fixes this: #880
Because previously I was not able to use "screenshare" recordings with Scalelite at all, see issue.

@ffdixon
Copy link
Member

ffdixon commented Jun 13, 2024

Thanks Jan, much appreciated. We'll review and give you feedback.

@Ithanil
Copy link
Contributor Author

Ithanil commented Jun 13, 2024

Thanks Jan, much appreciated. We'll review and give you feedback.

Alright, I'll fight with rubocop in the meanwhile.
EDIT: The ruby part is now part of a different PR, which is only meant to serve as an example on how to make non-player formats easily downloadable.

@farhatahmad farhatahmad merged commit 2cdaa04 into blindsidenetworks:master Jul 2, 2024
2 checks passed
@Ithanil Ithanil deleted the fix_protected_recordings branch July 2, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants