Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the protected recordings feature for all formats.
Description
Protected recordings have been broken, i.e. unprotected paths were served by nginx, since at least SL v1.5. This has been reported in several issues.
The changes to nginx locations for presentation and video formats were originally proposed by @schrd in #983 (comment)
Testing Steps
only the screenshare format is untested (of which I'm not sure if it actually works in any capacity at all), but it should behave just like the video formatEDIT: Screenshare format tested and works as well
Fixed issues
#983
#1008
#1046
I think it also fixes this: #880
Because previously I was not able to use "screenshare" recordings with Scalelite at all, see issue.