Sqlite wallet issue

[dangershony]

Change to RELEASE mode, run any node, create a wallet and query for address.

This will fail

[sondreb]

[sondreb]

The issue is many requests at the same time. If you request the balance in the browser and keep refreshing, it will quickly begin crashing.

Example: http://localhost:33333/api/wallet/balance?walletName=main&accountName=account%200

[MithrilMan]

does SQLite doesn't support multiple access to db?
that would be horrible, and in this case the implementation should have a lock (a slim one would suffice)

[sondreb]

Eventually when reloading, you'll get the error out like this:

[MithrilMan]

is it based on Dapper?
ensure the context is scoped, not a singleton, because if it's like EF, you can't run concurrent operation on the same context

[MithrilMan]

I checked fast, it seems dapper is used in WalletStore that is created once for each wallet, this mean it's a shared instance and since WalletStore create teh db connection in its constructor, that's the problem

in EF the dbcontext should be short living (like a unit of work), I suppose the same should be done on Dapper?

[dangershony]

I think dapper opens and closes the connection internally, I am not sure it needs to be short lived, but that's a place to look yes.

[dangershony]

But I am pretty sure the wallet has locks on it before even reaching the wallet store

[MithrilMan]

it doesnt, look the method pointed out by @sondreb, you'll find a loop that calls address.GetBalances, if you follow it you'll see there are no locks