Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure that each query against database uses a new connection object #300

Merged
merged 5 commits into from
Mar 9, 2021
Merged

Make sure that each query against database uses a new connection object #300

merged 5 commits into from
Mar 9, 2021

Conversation

dangershony
Copy link
Member

  • This is the smallest impact and quickest way to fix the issue with connections against sqlite database.
  • Closes Sqlite wallet issue #299

@sondreb
Make sure that each query against database uses a new connection object
2ea5342 
- This is the smallest impact and quickest way to fix the issue with connections against sqlite database.
- Closes #299
@dangershony
Copy link
Member Author

We probably need to run all tests locally on this one, I will do it now.

@dangershony dangershony requested a review from MithrilMan March 9, 2021 18:21
@MithrilMan
Copy link
Contributor

at a first glance I see you didn't disposed any connection.
Everytime you create a connection, you have to dispose it, use the using pattern

MithrilMan
MithrilMan reviewed Mar 9, 2021
View reviewed changes
Copy link
Contributor

@MithrilMan MithrilMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good to me, just added some comments

src/Features/Blockcore.Features.Wallet/Database/WalletStore.cs Show resolved Hide resolved
src/Features/Blockcore.Features.Wallet/Database/WalletStore.cs Outdated Show resolved Hide resolved
@sondreb sondreb merged commit 19596af into master Mar 9, 2021
@sondreb sondreb deleted the bug/sql-connections branch March 9, 2021 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sondreb sondreb sondreb left review comments

@MithrilMan MithrilMan MithrilMan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sqlite wallet issue
3 participants
@dangershony @MithrilMan @sondreb