Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update label for monthly minimum income #3609

Merged
merged 2 commits into from
Aug 23, 2023
Merged

fix: update label for monthly minimum income #3609

merged 2 commits into from
Aug 23, 2023

Conversation

KrissDrawing
Copy link
Collaborator

@KrissDrawing KrissDrawing commented Aug 21, 2023 •
edited
Loading

Pull Request Template

Issue Overview

This PR addresses #3567

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

Changes label for Monthly Minimum Income on partners site.

How Can This Be Tested/Reviewed?

go to edit listing in partners site -> add unit -> select fixed amount first label should be Monthly Minimum Income.
In listing details page click view on unit that has above filled. It should also be Monthly Minimum Income now.

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

@KrissDrawing KrissDrawing added the 1 review needed Requires 1 more review before ready to merge label Aug 21, 2023
@netlify
Copy link

netlify bot commented Aug 21, 2023 •
edited
Loading

✅ Deploy Preview for bloom-demo-public ready!

Name Link
🔨 Latest commit 34e18d1
🔍 Latest deploy log https://app.netlify.com/sites/bloom-demo-public/deploys/64e4b6920385e10008fa5d64
😎 Deploy Preview https://deploy-preview-3609--bloom-demo-public.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 21, 2023 •
edited
Loading

✅ Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit 34e18d1
🔍 Latest deploy log https://app.netlify.com/sites/bloom-exygy-dev/deploys/64e4b6929512a60008202738
😎 Deploy Preview https://deploy-preview-3609--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@KrissDrawing
Copy link
Collaborator Author

@sarahlazarich in task we have 2 versions of that string. In title there is Monthly Minimum Income and in description minimum monthly income.. I used here the first one, let me know if i should change that.

@sarahlazarich
Copy link
Collaborator

@KrissDrawing can we actually use "minimum monthly income"? Apologies for the discrepancy there.

@emilyjablonski emilyjablonski added the needs changes The author must make changes and then re-request review before merging label Aug 21, 2023
@KrissDrawing KrissDrawing removed the needs changes The author must make changes and then re-request review before merging label Aug 22, 2023
@netlify
Copy link

netlify bot commented Aug 22, 2023 •
edited
Loading

✅ Deploy Preview for bloom-partners-listings-approval ready!

Name Link
🔨 Latest commit 34e18d1
🔍 Latest deploy log https://app.netlify.com/sites/bloom-partners-listings-approval/deploys/64e4b692f9c4ba0008520786
😎 Deploy Preview https://deploy-preview-3609--bloom-partners-listings-approval.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@emilyjablonski emilyjablonski added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Aug 22, 2023
@KrissDrawing KrissDrawing merged commit a132cfa into main Aug 23, 2023
16 checks passed
@KrissDrawing KrissDrawing deleted the 3567/Change-Minimum-Income-to-Monthly-Minimum-Income--Partners branch August 23, 2023 14:27
@ludtkemorgan ludtkemorgan mentioned this pull request Aug 23, 2023
Merged
ludtkemorgan pushed a commit to housingbayarea/bloom that referenced this pull request Sep 5, 2023
@KrissDrawing @ludtkemorgan
fix: update label for monthly minimum income (bloom-housing#3609)
5570378 
* feat: update label for monthly minimum income

* fix: change string to Minimum Monthly Income
@ludtkemorgan ludtkemorgan mentioned this pull request Sep 5, 2023
Merged
ludtkemorgan added a commit to housingbayarea/bloom that referenced this pull request Sep 6, 2023
@ludtkemorgan @dependabot
@KrissDrawing @emilyjablonski @ColinBuyck @YazeedLoonat
Release: 2023-09-05 (#643)
b66af87 
* chore(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 (bloom-housing#3522)

* chore(deps): bump fast-xml-parser from 4.1.3 to 4.2.4 (bloom-housing#3500)

* chore(deps): bump @sideway/formula from 3.0.0 to 3.0.1 (bloom-housing#3354)

* fix: remove updated_at field from listing details page (bloom-housing#3527)

* feat: uptake field value v2 (bloom-housing#3509)

* fix: partners listings table sort by status (bloom-housing#3576)

* fix: add sorting by status

* fix: change default sort to status

* fix: default sorting by status

* fix: sort by application when the same status

* fix: orderBy test using default value

* fix: trigger backend sorting on initial load

* fix: add unsort icon to indicate that column might be sorted

* test: rollback test changes

* fix: use enums to order by status

* chore: upgrade uic

* refactor: use new seeds tag component (bloom-housing#3597)

* feat: submit for approval flow (bloom-housing#3598)

* fix: cors origin deploy preview issues (bloom-housing#3564)

* fix: update label for monthly minimum income (bloom-housing#3609)

* feat: update label for monthly minimum income

* fix: change string to Minimum Monthly Income

* feat: listings approval superadmin flow (bloom-housing#3611)

* fix: add backend url validation for url fields (bloom-housing#3568)

* fix: add backend url validation for url fields

* fix: validate only if externalUrl should be URL

* fix: use form values for application types on failed form submit

* fix: hide url field when no digital application

* fix: set proper default value to common digital application choice

* fix: add hasHttps decorator for second error variant

* fix: add four and five bedrooms keys to sort array (bloom-housing#3618)

* fix: sort table with listings approval statuses (bloom-housing#3622)

* test: add listings approval cypress tests (bloom-housing#3612)

* feat: listings approval emails (bloom-housing#3600)

* fix: use primary tag variants in partners (bloom-housing#3632)

* fix: amiPercentage being unset on unit edit (bloom-housing#3635)

---------

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Krzysztof Zięcina <kziecina@airnauts.com>
Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
Co-authored-by: ColinBuyck <53269332+ColinBuyck@users.noreply.github.com>
Co-authored-by: Yazeed Loonat <YazeedLoonat@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilyjablonski emilyjablonski emilyjablonski approved these changes

Assignees
No one assigned
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KrissDrawing @sarahlazarich @emilyjablonski