Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: uptake field value v2 #3509

Merged
merged 6 commits into from
Jul 10, 2023
Merged

feat: uptake field value v2 #3509

merged 6 commits into from
Jul 10, 2023

Conversation

emilyjablonski
Copy link
Collaborator

@emilyjablonski emilyjablonski commented Jun 14, 2023 •
edited
Loading

Pull Request Template

Issue Overview

This PR addresses #3396

  • This change addresses the issue in full

Description

This PR uptakes the new FieldValue component from seeds.
ZeroHeight Docs
Storybook

How Can This Be Tested/Reviewed?

As compared to dev, the styling is subtly different intentionally in terms of the font size, color, and padding.

To test this PR, check out the new component in the following places:

  • Partners listing detail page
  • Partners application detail page
  • Public application add household members page
  • Public application summary page

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

@netlify
Copy link

netlify bot commented Jun 14, 2023 •
edited
Loading

✅ Deploy Preview for bloom-demo-public ready!

Name Link
🔨 Latest commit e1fd710
🔍 Latest deploy log https://app.netlify.com/sites/bloom-demo-public/deploys/64a70cd425dba200086c779a
😎 Deploy Preview https://deploy-preview-3509--bloom-demo-public.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@emilyjablonski emilyjablonski added the 2 reviews needed Requires 2 more review before ready to merge label Jun 23, 2023
@emilyjablonski emilyjablonski marked this pull request as ready for review June 23, 2023 16:37
@emilyjablonski emilyjablonski removed the 2 reviews needed Requires 2 more review before ready to merge label Jun 23, 2023
@emilyjablonski emilyjablonski marked this pull request as draft June 23, 2023 16:39
@emilyjablonski emilyjablonski added the 2 reviews needed Requires 2 more review before ready to merge label Jun 23, 2023
@emilyjablonski emilyjablonski marked this pull request as ready for review June 23, 2023 16:39
@emilyjablonski emilyjablonski removed the 2 reviews needed Requires 2 more review before ready to merge label Jun 23, 2023
@netlify
Copy link

netlify bot commented Jun 23, 2023

✅ Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit d6f4680
🔍 Latest deploy log https://app.netlify.com/sites/bloom-exygy-dev/deploys/6495ff31c4df95000864ab82
😎 Deploy Preview https://deploy-preview-3509--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 23, 2023 •
edited
Loading

✅ Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit e1fd710
🔍 Latest deploy log https://app.netlify.com/sites/bloom-exygy-dev/deploys/64a70cd4a82b380008f28d91
😎 Deploy Preview https://deploy-preview-3509--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ludtkemorgan ludtkemorgan self-requested a review June 26, 2023 15:52
@emilyjablonski emilyjablonski added the 2 reviews needed Requires 2 more review before ready to merge label Jun 29, 2023
@ludtkemorgan
Copy link
Collaborator

The unit tests should be fixed with this change in ui-seeds: bloom-housing/ui-seeds#49

ludtkemorgan
ludtkemorgan reviewed Jun 29, 2023
View reviewed changes
Copy link
Collaborator

@ludtkemorgan ludtkemorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise this looks good. Are the failing cypress tests related to these changes? Looks like it is on a part of the code that you did touch.

@emilyjablonski
Copy link
Collaborator Author

@ludtkemorgan Yep it's blocked by this seeds PR: bloom-housing/ui-seeds#53

ludtkemorgan
ludtkemorgan approved these changes Jul 6, 2023
View reviewed changes
Copy link
Collaborator

@ludtkemorgan ludtkemorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏷️

@ludtkemorgan ludtkemorgan added 1 review needed Requires 1 more review before ready to merge and removed 2 reviews needed Requires 2 more review before ready to merge labels Jul 6, 2023
ColinBuyck
ColinBuyck approved these changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@ColinBuyck ColinBuyck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🪀 really like the subtle visual changes too!

@ColinBuyck ColinBuyck added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Jul 7, 2023
@emilyjablonski emilyjablonski merged commit 4c40a5e into main Jul 10, 2023
ludtkemorgan pushed a commit to housingbayarea/bloom that referenced this pull request Sep 5, 2023
@emilyjablonski @ludtkemorgan
feat: uptake field value v2 (bloom-housing#3509)
1bf7e1e
@ludtkemorgan ludtkemorgan mentioned this pull request Sep 5, 2023
Merged
ludtkemorgan added a commit to housingbayarea/bloom that referenced this pull request Sep 6, 2023
@ludtkemorgan @dependabot
@KrissDrawing @emilyjablonski @ColinBuyck @YazeedLoonat
Release: 2023-09-05 (#643)
b66af87 
* chore(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 (bloom-housing#3522)

* chore(deps): bump fast-xml-parser from 4.1.3 to 4.2.4 (bloom-housing#3500)

* chore(deps): bump @sideway/formula from 3.0.0 to 3.0.1 (bloom-housing#3354)

* fix: remove updated_at field from listing details page (bloom-housing#3527)

* feat: uptake field value v2 (bloom-housing#3509)

* fix: partners listings table sort by status (bloom-housing#3576)

* fix: add sorting by status

* fix: change default sort to status

* fix: default sorting by status

* fix: sort by application when the same status

* fix: orderBy test using default value

* fix: trigger backend sorting on initial load

* fix: add unsort icon to indicate that column might be sorted

* test: rollback test changes

* fix: use enums to order by status

* chore: upgrade uic

* refactor: use new seeds tag component (bloom-housing#3597)

* feat: submit for approval flow (bloom-housing#3598)

* fix: cors origin deploy preview issues (bloom-housing#3564)

* fix: update label for monthly minimum income (bloom-housing#3609)

* feat: update label for monthly minimum income

* fix: change string to Minimum Monthly Income

* feat: listings approval superadmin flow (bloom-housing#3611)

* fix: add backend url validation for url fields (bloom-housing#3568)

* fix: add backend url validation for url fields

* fix: validate only if externalUrl should be URL

* fix: use form values for application types on failed form submit

* fix: hide url field when no digital application

* fix: set proper default value to common digital application choice

* fix: add hasHttps decorator for second error variant

* fix: add four and five bedrooms keys to sort array (bloom-housing#3618)

* fix: sort table with listings approval statuses (bloom-housing#3622)

* test: add listings approval cypress tests (bloom-housing#3612)

* feat: listings approval emails (bloom-housing#3600)

* fix: use primary tag variants in partners (bloom-housing#3632)

* fix: amiPercentage being unset on unit edit (bloom-housing#3635)

---------

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Krzysztof Zięcina <kziecina@airnauts.com>
Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
Co-authored-by: ColinBuyck <53269332+ColinBuyck@users.noreply.github.com>
Co-authored-by: Yazeed Loonat <YazeedLoonat@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColinBuyck ColinBuyck ColinBuyck approved these changes

@ludtkemorgan ludtkemorgan ludtkemorgan approved these changes

Assignees
No one assigned
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emilyjablonski @ludtkemorgan @ColinBuyck