Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add test ids #53

Merged
merged 1 commit into from
Jul 5, 2023
Merged

fix: add test ids #53

merged 1 commit into from
Jul 5, 2023

Conversation

emilyjablonski
Copy link
Contributor

Issue Overview

This PR addresses #52

Description

Adds some test ids to some of our smaller components to be able to target them in the public/partners site Cypress tests

Checklist:

  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have exported any new components
  • My commit message(s) and PR title are polished in the conventional commit format, and any breaking changes are indicated in the message and are well-described

@netlify
Copy link

netlify bot commented Jul 5, 2023

Deploy Preview for storybook-ui-seeds ready!

Name Link
🔨 Latest commit 47b77fa
🔍 Latest deploy log https://app.netlify.com/sites/storybook-ui-seeds/deploys/64a58c6985c6090008480483
😎 Deploy Preview https://deploy-preview-53--storybook-ui-seeds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@ColinBuyck ColinBuyck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐻‍❄️

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

🎉 This PR is included in version 1.7.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants