Skip to content

Commit

Permalink
[PCCT-SideSheet] Set the extra flags name correctly
Browse files Browse the repository at this point in the history
Removes unnecessary prefix from flag names.

(cherry picked from commit 28fa3fe)

Bug: 1427215
Change-Id: I3227464bab2584510f8ab2616fa3e88db1302b57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4369074
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Kevin Grosu <kgrosu@google.com>
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1121861}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4374832
Cr-Commit-Position: refs/branch-heads/5672@{#55}
Cr-Branched-From: 5f2a724-refs/heads/main@{#1121455}
  • Loading branch information
JinsukKim authored and Chromium LUCI CQ committed Mar 27, 2023
1 parent 43be564 commit e157e87
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -112,14 +112,14 @@ public class CustomTabIntentDataProvider extends BrowserServicesIntentDataProvid
* layout.
*/
public static final String EXTRA_ACTIVITY_SIDE_SHEET_POSITION =
"androidx.browser.customtabs.extra.EXTRA_ACTIVITY_SIDE_SHEET_POSITION";
"androidx.browser.customtabs.extra.ACTIVITY_SIDE_SHEET_POSITION";

/**
* Extra that defines the behavior of the opening animation of the side sheet.
* It is set to {@link #ACTIVITY_SIDE_SHEET_SLIDE_IN_FROM_SIDE} by default.
*/
public static final String EXTRA_ACTIVITY_SIDE_SHEET_SLIDE_IN_BEHAVIOR =
"androidx.browser.customtabs.extra.EXTRA_ACTIVITY_SIDE_SHEET_SLIDE_IN_BEHAVIOR";
"androidx.browser.customtabs.extra.ACTIVITY_SIDE_SHEET_SLIDE_IN_BEHAVIOR";

/**
* Extra used to keep the caller alive. Its value is an Intent.
Expand Down Expand Up @@ -260,7 +260,7 @@ public class CustomTabIntentDataProvider extends BrowserServicesIntentDataProvid

/** Extra that enables the maximization button on the side sheet Custom Tab toolbar. */
public static final String EXTRA_ACTIVITY_SIDE_SHEET_ENABLE_MAXIMIZATION =
"androix.browser.customtabs.extra.EXTRA_ACTIVITY_SIDE_SHEET_ENABLE_MAXIMIZATION";
"androix.browser.customtabs.extra.ACTIVITY_SIDE_SHEET_ENABLE_MAXIMIZATION";

/**
* Extra that, if set in combination with
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ public class MainActivity

/** Extra that enables the maximization button on the side sheet Custom Tab toolbar. */
public static final String EXTRA_ACTIVITY_SIDE_SHEET_ENABLE_MAXIMIZATION =
"androix.browser.customtabs.extra.EXTRA_ACTIVITY_SIDE_SHEET_ENABLE_MAXIMIZATION";
"androix.browser.customtabs.extra.ACTIVITY_SIDE_SHEET_ENABLE_MAXIMIZATION";

/**
* Minimal height the bottom sheet CCT should show is half of the display height.
Expand Down Expand Up @@ -152,14 +152,14 @@ public class MainActivity
public static final int ACTIVITY_SIDE_SHEET_POSITION_END = 2;

public static final String EXTRA_ACTIVITY_SIDE_SHEET_POSITION =
"androidx.browser.customtabs.extra.EXTRA_ACTIVITY_SIDE_SHEET_POSITION";
"androidx.browser.customtabs.extra.ACTIVITY_SIDE_SHEET_POSITION";

public static final int ACTIVITY_SIDE_SHEET_SLIDE_IN_DEFAULT = 0;
public static final int ACTIVITY_SIDE_SHEET_SLIDE_IN_FROM_BOTTOM = 1;
public static final int ACTIVITY_SIDE_SHEET_SLIDE_IN_FROM_SIDE = 2;

public static final String EXTRA_ACTIVITY_SIDE_SHEET_SLIDE_IN_BEHAVIOR =
"androidx.browser.customtabs.extra.EXTRA_ACTIVITY_SIDE_SHEET_SLIDE_IN_BEHAVIOR";
"androidx.browser.customtabs.extra.ACTIVITY_SIDE_SHEET_SLIDE_IN_BEHAVIOR";

/**
* Once per second, asks the framework for the process importance, and logs any change.
Expand Down

0 comments on commit e157e87

Please sign in to comment.