Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with web security certificates #55

Closed
Anthony-B-Russo10 opened this issue Mar 25, 2022 · 4 comments
Closed

Issues with web security certificates #55

Anthony-B-Russo10 opened this issue Mar 25, 2022 · 4 comments

Comments

@Anthony-B-Russo10
Copy link

The current builds are having issues saying the root certificate of certain sites are invalid, this issue appeared only on the most recent builds. This issue is not present as of older builds and on other browsers.
Screen Shot 2022-03-24 at 9 42 49 PM
Screen Shot 2022-03-24 at 9 43 28 PM
Screen Shot 2022-03-24 at 9 43 43 PM
Examples of the issue.
@aeiouaeiouaeiouaeiouaeiouaeiou
Copy link

This script should help you.

@Wowfunhappy
Copy link

I cannot replicate this in 10.7 as of build 986492. Note that I have manually installed the ISRG X1 root certificate (as everyone should), however that would affect all browsers and versions.

@blueboxd
Copy link
Owner

Root certificate DST Root CA X3 is already expired on 2021/09/30.
So, this is correct behavior.
(for an unknown reason, this certificate was determined to be valid by Chromium until recently...A moratorium for Let's Encrypt?🤔 )

To resolve, please install ISRG Root X1 as CA.
Download it and
sudo security add-trusted-cert -d -r trustRoot -k /System/Library/Keychains/SystemRootCertificates.keychain isrgrootx1.pem.txt.

@pjpreilly
Copy link

pjpreilly commented Apr 1, 2022 •
edited
Loading

This was a good article I used..
https://macresearch.org/dst-root-ca-x3-expired-mac/

blueboxd pushed a commit that referenced this issue Jun 22, 2022
Revert "Set ShareThisTabInsteadButtonGetDisplayMedia to ENABLED_BY_DE…
1e48562 
…FAULT"

This reverts commit 023547d.

Reason for revert: See crbug.com/1325266 for details.

Original change's description:
> Set ShareThisTabInsteadButtonGetDisplayMedia to ENABLED_BY_DEFAULT
>
> The issue of audio staying with the old tab (https://crbug.com/1307710)
> is fixed (https://crrev.com/c/3629583).
>
> Bug: 1307710, 1325266
> Change-Id: I9d64d0d2aa15bb48fa99737def26259ad936f544
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3629309
> Commit-Queue: Tove Petersson <tovep@chromium.org>
> Reviewed-by: Elad Alon <eladalon@chromium.org>
> Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1001723}

(cherry picked from commit 16695eb)

Bug: 1307710, 1325266
Change-Id: Ib34a9eb7fc37e5fad7ad0fad802f5e23823f62c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3644736
Reviewed-by: Tove Petersson <tovep@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Auto-Submit: Elad Alon <eladalon@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1003249}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3652045
Commit-Queue: Prudhvikumar Bommana <pbommana@google.com>
Owners-Override: Prudhvikumar Bommana <pbommana@google.com>
Reviewed-by: Prudhvikumar Bommana <pbommana@google.com>
Cr-Commit-Position: refs/branch-heads/5060@{#55}
Cr-Branched-From: b83393d-refs/heads/main@{#1002911}
blueboxd pushed a commit that referenced this issue Aug 31, 2022
[SearchResumption] Update the color for the chevron in dark theme.
820aba1 
Before: https://screenshot.googleplex.com/7j63AZ7dBR7vban
After: https://screenshot.googleplex.com/5rS4Xj66qYSqNK3

(cherry picked from commit 2151d54)

Bug: 1347075
Change-Id: I2c6cb47cf25e00c1dab722e16a2b21c32ffd05d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3787013
Reviewed-by: Xi Han <hanxi@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Commit-Queue: Hao Dong <spdonghao@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1027968}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3787137
Cr-Commit-Position: refs/branch-heads/5195@{#55}
Cr-Branched-From: 7aa3f07-refs/heads/main@{#1027018}
blueboxd pushed a commit that referenced this issue Sep 29, 2022
@aleventhal
Merge 106: Avoid possible out-of-bounds array access
27d8732 
Speculative fix for rare crash. It's probable that firing the event
on the parent somehow caused its children to be invalidated.

(cherry picked from commit 2cfa103)

Bug: 1352653
Change-Id: Ib69d2bd5491099e4795d4b098662d0278b48f2a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3846096
Reviewed-by: Daniel Libby <dlibby@microsoft.com>
Auto-Submit: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Daniel Libby <dlibby@microsoft.com>
Cr-Original-Commit-Position: refs/heads/main@{#1037960}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3852861
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5249@{#55}
Cr-Branched-From: 4f7bea5-refs/heads/main@{#1036826}
blueboxd pushed a commit that referenced this issue Nov 24, 2022
@bungeman
Roll src/third_party/expat/src/ 53fbdf5b8..441f98d02 (135 commits)
06fef20 
https://chromium.googlesource.com/external/github.com/libexpat/libexpat.git/+log/53fbdf5b8925..441f98d02dea

$ git log 53fbdf5b8..441f98d02 --date=short --no-merges --format='%ad %ae %s'
2022-11-04 sebastian coverage.yml: Drop ppa:ondrej/php removal
2022-11-01 sean Simplify code by using SB_BYTE_TYPE macro
2022-10-21 sean Fixed some clang -Wcast-qual warnings
2022-10-27 sean Fixed some -Wcast-qual warnings by just using NULL for default value of output param
2022-11-01 sebastian Changes: Document #673
2022-11-01 sebastian cmake: Resolve duplication related to building examples
2022-10-30 sebastian Sync file headers
2022-10-30 sebastian examples/element_declarations.c: Resolve recursion
2022-10-24 sebastian examples/element_declarations.c: Handle element declarations rather than elements
2022-10-24 sebastian examples: Clone example "examples" to "element_declarations"
2022-10-21 sean Fixed getDebugLevel handling of empty env var
2022-10-26 rosenp cmake: lowercase off_t and size_t
2022-10-26 sean Partly fixed a clang -Wreserved-id-macro warning with _GNU_SOURCE
2022-10-24 sean Replaced all sprintf with safer snprintf
2022-10-21 sean Fixed cppcheck 2.9 warnings
2022-10-21 sean Fixed most clang -Wunused-macros warnings
2022-10-25 sebastian Changes: Add note on impact of CVE-2022-43680
2022-10-21 sean Fixed most clang -Wreserved-id-macro warnings
2022-10-21 sean Fixed all clang -Wconditional-uninitialized warnings
2022-10-24 sebastian Set release date for version 2.5.0
2022-10-24 sebastian Changes: Document #656 #658
2022-10-24 sebastian Bump version to 2.5.0
2022-10-24 sebastian Bump version info from 9:9:8 to 9:10:8
2022-10-24 sebastian Sync file headers
2022-10-24 sebastian Changes: Document #666
2022-10-24 sebastian cmake: Resolve duplication related to building examples
2022-10-24 sebastian examples: Add some whitespace for readability
2022-10-24 sebastian examples: Make use of XML_GetBuffer
2022-10-24 sebastian examples/elements.c: Resolve unused include of <wchar.h>
2022-10-24 sebastian examples/elements.c: Be consistent across examples regarding OOM detection
2022-10-24 sebastian examples: Be consistent across examples regarding read looping and main exit
2022-10-24 sebastian examples/elements.c: Be consistent in parse error reporting format across examples
2022-10-24 sebastian examples/outline.c: Be consistent in main loop exit across examples
2022-10-24 sebastian examples/outline.c: Make element handler signatures consistent across examples
2022-10-24 sebastian examples/outline.c: Make use of BUFSIZ from stdio.h consistent across examples
2022-10-24 sebastian examples: Make passing of depth pointer consistent across examples
2022-10-24 sebastian examples: Resolve use of unused variables argc and argv
2022-09-21 sebastian Changes: Document #649
2022-09-19 sebastian tests: Cover overeager DTD destruction in XML_ExternalEntityParserCreate
2022-09-20 sebastian lib: Fix overeager DTD destruction in XML_ExternalEntityParserCreate
2022-10-24 49699333+dependabot[bot] Actions(deps): Bump actions/upload-artifact from 3.1.0 to 3.1.1
2022-10-24 sebastian examples/outline.c: Rename "Buff" to "buf" for consistency across examples
2022-10-24 sebastian examples/outline.c: Make "Buff" a local variable
2022-10-24 sebastian examples/outline.c: Rename variable "p" to "parser"
2022-10-23 sebastian Protect expat_config.h against multiple inclusion
2022-09-25 sebastian Changes: Document #613
2022-09-25 sebastian tests: Cover suspend with inside nested entites in internalEntityProcessor
2022-09-25 sebastian lib: Fix suspend with inside nested entites in internalEntityProcessor
2022-09-25 sebastian lib: Simplify control flow in internalEntityProcessor
2022-10-10 49699333+dependabot[bot] Actions(deps): Bump actions/checkout from 3.0.2 to 3.1.0
(...)
2022-08-21 sebastian coverage.sh: Fix name collision for -funsigned-char
2022-08-20 sebastian lib: Fix compilation for -D__USE_MINGW_ANSI_STDIO=0
2022-08-21 sebastian coverage.sh: Exclude MinGW headers (stdio.h and stdlib.h)
2022-08-21 sebastian coverage.sh: Inline exclusion patterns (for upcoming change)
2022-08-20 t-0 File expat/fuzz/.gitignore changed to not ignore already-committed source files (fixes #630) (#631)
2022-08-17 rhodri Ensure raw tagnames are safe exiting internalEntityParser
2022-08-11 sebastian Changes: Document past Autotools Cmake template adjustments in more detail
2022-08-11 sebastian autotools: Sync CMake templates with CMake 3.22
2022-08-02 sebastian cmake: Produce libexpat-1.dll with MinGW in line with GNU Autotools
2022-07-30 sebastian cmake: Apply .def file when linking with MinGW
2022-07-30 sebastian cmake|windows: Render .def file from a template to fix linking
2022-07-27 sebastian Changes: Document #608 and #620
2022-07-27 sebastian readme: Get CMake variables documentation back in sync
2022-07-27 sebastian cmake: Make all variable documentation start with a capital letter
2022-07-27 sebastian cmake: Improve documentation of variables EXPAT_*_POSTFIX
2022-07-27 sebastian cmake: Fix a CMAKE_*_POSTFIX leftover from pull request #608
2022-07-27 sebastian actions: Be explicit about macos-11
2022-07-27 sebastian actions: Migrate from deprecated macos-10.15 to macos-11
2022-06-29 david.faure Set target properties *_POSTFIX instead of global vars CMAKE_*_POSTFIX
2022-07-22 thijs fix(docs) update XML_DTD symbol visibility
2022-07-18 rosenp expat: fix def files for MinGW
2022-07-15 sebastian lib: Address Cppcheck 2.8.1 warning
2022-07-14 sebastian COPYING: cp expat/COPYING ./
2022-07-14 sebastian Sync file headers
2022-07-14 sebastian .mailmap: Add Martin Ettl
2022-05-23 49699333+dependabot[bot] Actions(deps): Bump actions/upload-artifact from 3.0.0 to 3.1.0
2022-04-25 49699333+dependabot[bot] Actions(deps): Bump actions/checkout from 3.0.1 to 3.0.2
2022-04-20 orbitcowboy [style] Added parentheses around macro arguments (#601)
2022-04-18 49699333+dependabot[bot] Actions(deps): Bump actions/checkout from 3.0.0 to 3.0.1
2022-04-16 sebastian CMake: Add missing XML_STATIC to test runners and fuzzers on Windows
2022-04-16 sebastian CMake: Add missing section comment for fuzzers
2022-04-16 sebastian CMake: Extract loop to resolve runtests/runtestspp duplication
2022-04-12 sebastian appveyor.yml: Add MSVC 2022
2022-04-08 sebastian autotools: Sync expat.cmake to agree with CI
2022-04-01 ettl.martin78 [STYLE] Added parentheses around macro argument
2022-04-01 ettl.martin78 Fixed typo in nsattcmp attribute handling
2022-03-30 ettl.martin78 Assign LPVOID pointer with NULL before it's being used
2022-03-28 sebastian Set expected release date for 2.4.8
2022-03-28 sebastian Sync file headers
2022-03-28 sebastian Bump version to 2.4.8
2022-03-28 sebastian Bump version info from 9:7:8 to 9:8:8
2022-03-25 sebastian Actions: Resolve hardcoding of "bionic" for maintainability
2022-03-25 sebastian Actions: Upgrade Clang from 13 to 14
2022-03-24 sebastian Actions: Migrate off moving Git tags
2022-03-24 sebastian Actions: Make robust toward outdated images
2022-03-24 sebastian Changes: Document #587
2022-03-24 sebastian CMake: Fix pkg-config section "Libs" for MSVC
2022-03-24 sebastian pkg-config: Move "-lm" from section "Libs" to section "Libs.private"
2022-03-07 sebastian Changes: Document #55 and #582
2022-03-07 sebastian CMake: Enforce library versioning compatible with GNU Libtool for macOS

Created with:
  roll-dep src/third_party/expat/src
R=bungeman@chromium.org,dcheng@chromium.org

Change-Id: Ieb1a8ce13fbe1aee6fa9c6642a6aa06ffbeb18d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4047907
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1074808}
blueboxd pushed a commit that referenced this issue Nov 30, 2022
@sdefresne
[ios] No allocation for kDefaultRanking
470f612 
Convert the helper `List` function to a template function allowing
to replace `kDefaultRanking` by a const array. This removes copies
of the array and allocation and destructions of `std::vector<>`.

(cherry picked from commit 0bd1d24)

Bug: none
Change-Id: Ia662e9d84e902084ef22cae91c104c65d436fee6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3952310
Reviewed-by: Benjamin Williams <bwwilliams@google.com>
Commit-Queue: Benjamin Williams <bwwilliams@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1058956}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3961191
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/branch-heads/5359@{#55}
Cr-Branched-From: 27d3765-refs/heads/main@{#1058933}
blueboxd pushed a commit that referenced this issue Feb 8, 2023
Updating XTBs based on .GRDs from branch 5481
c50ec4d 
Change-Id: I71efb2c6fb443867d7aee0260422fa9d5d850b10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4120736
Auto-Submit: Ben Mason <benmason@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5481@{#55}
Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}
blueboxd pushed a commit that referenced this issue Mar 7, 2023
@LanWei22
Fix a crash when using OptionalBooleanToBool on undefined value
9200457 
if we type in a field which has not been autofilled, |was_autofilled| is
undefined, so |filled_value_was_modified| is also undefined. For
|filled_value_was_modified| we should set it in both filling and
typing cases, we want to set it to be true when filling happens first
and the user types into the field, if autofill happens without a user
editing to it, it should be false.

(cherry picked from commit 35c2078)

Bug: 1410898
Change-Id: I6c37b82c02fb85d7f647ff88ca4d795b3b7b986d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4201202
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1098530}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4209028
Auto-Submit: Lan Wei <lanwei@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/branch-heads/5563@{#55}
Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
blueboxd pushed a commit that referenced this issue Apr 14, 2023
[M112] Add ownership check to rollback network removal
8f9e487 
Rollback configures some previously policy configured networks
temporarily as user configured to allow for re-enrollment. Once network
policies are applied, we want to delete the temporary networks. Before
this change, we were deleting networks too early because policies
applied signal is sent on the welcome screen.

While we're at it, also make sure we only delete networks if device
policy was applied, not user policy.

Test: Deploy a modified version of Chrome that does not do auto
      re-enrollment.

      touch /mnt/stateful_partition/.save_rollback_data &&
      start oobe_config_save &&
      cat /var/lib/oobe_config_save/data_for_pstore
      > /dev/pmsg0 &&
      echo -e > /dev/pmsg0 &&
      rm -rf /home/.shadow &&
      crossystem clear_tpm_owner_request=1 &&

      reboot

      vim /var/cache/shill/default.profile
      -> Check that policy configured networks are present.

(cherry picked from commit 8335885)

Bug: b:270039762
Change-Id: I8ac51b4c808e8685d40a5b668799edf4df1a1cd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4281518
Commit-Queue: Miriam Polzer <mpolzer@google.com>
Reviewed-by: Victor-Gabriel Savu <vsavu@google.com>
Reviewed-by: Igor <igorcov@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1109512}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4296019
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/branch-heads/5615@{#55}
Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
blueboxd pushed a commit that referenced this issue May 9, 2023
@JinsukKim
[PCCT-SideSheet] Set the extra flags name correctly
e157e87 
Removes unnecessary prefix from flag names.

(cherry picked from commit 28fa3fe)

Bug: 1427215
Change-Id: I3227464bab2584510f8ab2616fa3e88db1302b57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4369074
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Kevin Grosu <kgrosu@google.com>
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1121861}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4374832
Cr-Commit-Position: refs/branch-heads/5672@{#55}
Cr-Branched-From: 5f2a724-refs/heads/main@{#1121455}
blueboxd pushed a commit that referenced this issue May 27, 2023
@natechapin
Delay starting the loading UI for navigateEvent.intercept()
b50e12d 
In a common use case of the navigateEvent.intercept() (the case
where no optional `handler` is provided), we pulse the the loading UI
for very brief period of time. If several navigations happen in rapid
succession (say, a website that updates the url on every keystroke),
this makes the loading UI extremely jittery (in Chrome desktop, we rapidly swap back and forth between the loading spinner and the
favicon).

Instead of immediately starting the loading UI, start a 50ms timer,
and if the navigation remains in progress long enough that the timer
fires, then start showing the loading UI. Jittering is still possible,
but much less likely since it will now avoid the modal case.

https://chromium-review.googlesource.com/c/chromium/src/+/4408275
introduce a way to "upgrade" an in-progress same-document navigation
that isn't currently showing loading UI to start showing it.
RenderFrameHostImpl::StartLoadingForAsyncNavigationApiCommit() uses
this new capability.

This also fixes long-standing issue the navigation API's loading UI
integration: we had no way to change a browser-initiated same-document
navigation to start showing loading UI. This CL fixes that case
incidentally.

(cherry picked from commit 9c9fab8)

Bug: 1241202
Change-Id: I089a4d583c0d7732cea1fc9097687edc141cf079
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4390342
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1135624}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4485119
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/branch-heads/5735@{#55}
Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Wowfunhappy @pjpreilly @blueboxd @Anthony-B-Russo10 @aeiouaeiouaeiouaeiouaeiouaeiou