Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canary Crashes on Page Restore.... #50

Closed
pjpreilly opened this issue Feb 20, 2022 · 14 comments
Closed

Canary Crashes on Page Restore.... #50

pjpreilly opened this issue Feb 20, 2022 · 14 comments

Comments

@pjpreilly
Copy link

Process: Chromium [186]
Path: /Applications/Chromium.app/Contents/MacOS/Chromium
Identifier: org.chromium.Chromium
Version: 101.0.4900.0 (4900.0)
Code Type: X86-64 (Native)
Parent Process: launchd [117]

Date/Time: 2022-02-20 12:11:44.166 -0500
OS Version: Mac OS X 10.7.5 (11G63)
Report Version: 9

Crashed Thread: 0 CrBrowserMain Dispatch queue: com.apple.main-thread

Exception Type: EXC_BREAKPOINT (SIGTRAP)
Exception Codes: 0x0000000000000002, 0x0000000000000000

Application Specific Information:
objc[186]: garbage collection is OFF
Performing @selector(openHistoryMenuItem:) from sender NSMenuItem 0x7f9dddab8cf0

Thread 0 Crashed:: CrBrowserMain Dispatch queue: com.apple.main-thread
0 org.chromium.Chromium.framework 0x000000011134dfbc content::NavigationControllerImpl::Restore(int, content::RestoreType, std::__1::vector<std::__1::unique_ptr<content::NavigationEntry, std::__1::default_deletecontent::NavigationEntry >, std::__1::allocator<std::__1::unique_ptr<content::NavigationEntry, std::__1::default_deletecontent::NavigationEntry > > >) + 908
1 org.chromium.Chromium.framework 0x00000001169d8b98 chrome::(anonymous namespace)::CreateRestoredTab(Browser, std::__1::vector<sessions::SerializedNavigationEntry, std::__1::allocatorsessions::SerializedNavigationEntry > const&, int, std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > const&, base::TimeTicks, content::SessionStorageNamespace*, sessions::SerializedUserAgentOverride const&, std::__1::map<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >, std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >, std::__1::less<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > >, std::__1::allocator<std::__1::pair<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > const, std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > > > > const&, bool, bool) + 760
2 org.chromium.Chromium.framework 0x00000001169d882c chrome::AddRestoredTab(Browser*, std::__1::vector<sessions::SerializedNavigationEntry, std::__1::allocatorsessions::SerializedNavigationEntry > const&, int, int, std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > const&, absl::optional<tab_groups::TabGroupId>, bool, bool, base::TimeTicks, content::SessionStorageNamespace*, sessions::SerializedUserAgentOverride const&, std::__1::map<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >, std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >, std::__1::less<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > >, std::__1::allocator<std::__1::pair<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > const, std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > > > > const&, bool) + 124
3 org.chromium.Chromium.framework 0x00000001169d4dbe BrowserLiveTabContext::AddRestoredTab(std::__1::vector<sessions::SerializedNavigationEntry, std::__1::allocatorsessions::SerializedNavigationEntry > const&, int, int, std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > const&, absl::optional<tab_groups::TabGroupId>, tab_groups::TabGroupVisualData const&, bool, bool, sessions::PlatformSpecificTabData const*, sessions::SerializedUserAgentOverride const&, std::__1::map<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >, std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >, std::__1::less<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > >, std::__1::allocator<std::__1::pair<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > const, std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > > > > const&, SessionID const*) + 398
@pjpreilly
Copy link
Author

I had to bookmark 3 pages with multiple tabs in v100 & restore them from bookmarks in v101. The restore function as well as the saved history restore caused v101 to crash each time.

@pjpreilly
Copy link
Author

The transition to v101 fro v100 went fine on a mackbook 4,1 with only one page with multiple tabs...? Maybe a multiple page scenario bug...

@Wowfunhappy
Copy link

Wowfunhappy commented Feb 22, 2022 •
edited
Loading

Total guess on my part—I haven’t tested anything—but this feels like a Chrome Canary issue rather than something specific to Chromium Legacy.

@Wowfunhappy Wowfunhappy mentioned this issue Mar 29, 2022
Closed
@pjpreilly
Copy link
Author

Total guess on my part—I haven’t tested anything—but this feels like a Chrome Canary issue rather than something specific to Chromium Legacy.

I think this is related to going backwards from Canary to Stable......

@Wowfunhappy
Copy link

Does it only crash when you restore pages from the newer version in the older version, or does it also crash when you restore pages from the same version? The former probably isn't a bug.

@pjpreilly
Copy link
Author

... I'm not sure .. but all hell was breaking out when going from Canary back to Stable....so I stopped doing it. I've been backing up each version of Canary that works before updating to the newer.

@Wowfunhappy
Copy link

Wowfunhappy commented Mar 30, 2022 •
edited
Loading

Are you currently able to quit with a set of tabs open, then re-open Chromium (the same version) and restore them? If you can, I don't think there's a bug here, unless I'm misunderstanding.

@pjpreilly
Copy link
Author

Are you currently able to quit with a set of tabs open, then re-open Chromium (the same version) and restore them? If you can, I don't think there's a bug here, unless I'm misunderstanding.

... why don't you just try it... open a bunch of tabs in Canary with startup set to open the tabs from my last session set. Then quit & open Stable. It was crashing on initial launch then on subsequent launches RESTORE offering would then crash. I had to reopen the tabs from Bookmarks & NOT History to proceed. Like I said I don't do it anymore since it is an ass pain.

@Wowfunhappy
Copy link

Wowfunhappy commented Mar 30, 2022 •
edited
Loading

open a bunch of tabs in Canary with startup set to open the tabs from my last session set. Then quit & open Stable.

That's not a bug. You're restoring a profile from a newer version from an older version. That usually works in my experience, but only because of luck. It's going to break sometimes. The profile isn't stable across versions, Google probably changed something.

@pjpreilly
Copy link
Author

open a bunch of tabs in Canary with startup set to open the tabs from my last session set. Then quit & open Stable.

That's not a bug. You're restoring a profile from a newer version from an older version. That usually works in my experience, but only because of luck. It's going to break sometimes. The profile isn't stable across versions, Google probably changed something.

... yep, that's why I'm not doing it.....

@Wowfunhappy
Copy link

Wowfunhappy commented Mar 30, 2022 •
edited
Loading

Gotcha, but I don't think there's an issue here. Chromium is behaving as expected.

@pjpreilly
Copy link
Author

Gotcha, but I don't think there's an issue here. Chromium is behaving as expected.

... so true....you can't go back....

@Wowfunhappy
Copy link

Wowfunhappy commented Mar 30, 2022 •
edited
Loading

Should this issue be closed then? Since there's nothing to fix.

@pjpreilly
Copy link
Author

Should this issue be closed then? Since there's nothing to fix.

I will...but beware...

blueboxd pushed a commit that referenced this issue Jun 22, 2022
@yaoxiachromium
[Merge M103] [shared storage] disallow runURLSelectionOperation in fe…
48151bd 
…nced frame

This is to prevent the potential leakage where lots of nested fenced
frames are created from runURLSelectionOperation(), and then an user
activation could let them all navigate to a destination page and leak
log(num urls) bits each.

Also add the checks to disallow the shared storage methods in detached
iframes.

Explainer: https://github.com/pythagoraskitty/shared-storage/blob/main/README.md#url-selection

(cherry picked from commit e95f5d3)

Bug: 1324997
Change-Id: I611179f8dacb6758513fb972b6272c13b6a67b10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3643136
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1003307}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3650879
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Yao Xiao <yaoxia@chromium.org>
Auto-Submit: Yao Xiao <yaoxia@chromium.org>
Cr-Commit-Position: refs/branch-heads/5060@{#50}
Cr-Branched-From: b83393d-refs/heads/main@{#1002911}
blueboxd pushed a commit that referenced this issue Aug 31, 2022
@lilles
[@container] Clear ContainerQueryData on detach
e18f3cc 
If not re-attaching, there should be no reason to keep the container
query data. Also fixes a DCHECK/crash that if the element had a
container query evaluator the last lifecycle update, and still has the
same one, the old ComputedStyle should be non-null.

(cherry picked from commit e7623ad)

Bug: 1342750
Change-Id: I743abe62ec7597eccf1f9b146d60668d861b62d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3782882
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1027777}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3784228
Cr-Commit-Position: refs/branch-heads/5195@{#50}
Cr-Branched-From: 7aa3f07-refs/heads/main@{#1027018}
blueboxd pushed a commit that referenced this issue Sep 29, 2022
[M106]Add a method to tweak add account flow result in FakeAccountMan…
3506f1d 
…agerFacade for tests

This cl adds a new method in FakeAccountManagerFacade that will let
testing add account flow in chrome more easier. This method allows
tests to tweak the results of the add account flow.
This cl also migrates some test suites to use this method.

(cherry picked from commit 9ec29e2)

Bug: 1351315
Change-Id: Ib90f8d9117c71b8e9bc1907d2ebefc686e274177
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3842170
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Auto-Submit: Tanmoy Mollik <triploblastic@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1037714}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3850922
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Auto-Submit: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Tanmoy Mollik <triploblastic@chromium.org>
Cr-Commit-Position: refs/branch-heads/5249@{#50}
Cr-Branched-From: 4f7bea5-refs/heads/main@{#1036826}
blueboxd pushed a commit that referenced this issue Nov 30, 2022
Incrementing VERSION to 108.0.5359.7
9699c50 
Change-Id: I2b5d9fe49ecb12cfe37a688f8f6e785135e3d7b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3960436
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5359@{#50}
Cr-Branched-From: 27d3765-refs/heads/main@{#1058933}
blueboxd pushed a commit that referenced this issue Feb 8, 2023
Update proto definitions for KidsManagementService
6113398 
This updates the client protos used in Chrome to match the format of
the messages on the wire.

Tested live, by checking that parent information is now correctly
displayed on the child device when the relevant flag is enabled.

(cherry picked from commit 8998948)

Bug: 1402238
Change-Id: I4edb0957092d0207b6f0cc3670526107ab86e03b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4111859
Auto-Submit: James Lee <ljjlee@google.com>
Reviewed-by: Nohemi Fernandez <fernandex@chromium.org>
Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1085415}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4120421
Auto-Submit: Nohemi Fernandez <fernandex@chromium.org>
Reviewed-by: James Lee <ljjlee@google.com>
Commit-Queue: James Lee <ljjlee@google.com>
Cr-Commit-Position: refs/branch-heads/5481@{#50}
Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}
blueboxd pushed a commit that referenced this issue Mar 7, 2023
Revert "Support BufferQueue on Mac"
537550f 
This reverts commit 3427060.

Reason for revert: b/266848353 - broke Canvas app on CrOS

Original change's description:
> Support BufferQueue on Mac
>
> This CL does NOT enable BQ on Mac.
>
> - Don't call PrepareRenderPassOverlay for root render passes
> - Ignore InUseByWindowServer for root rp overlays
> - Don't bother calling DidReceiveReleasedOverlays for root rp overlays
> - Also cleanup some render pass backing code for root rps, making logic
>   simpler.
>
> Bug: 1322528
> Change-Id: I4ae0897a5803ded347d05159ddc1b06031948595
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4089938
> Commit-Queue: Kevin Haslett <khaslett@chromium.org>
> Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
> Reviewed-by: Kyle Charbonneau <kylechar@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1095874}

(cherry picked from commit bccdfba)

Bug: 1322528, 1411453
Change-Id: I0fbf816d25e382c3070f03afec84123edf044d3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4197743
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Kevin Haslett <khaslett@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Kyle Charbonneau <kylechar@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1098196}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4206107
Reviewed-by: Peter McNeeley <petermcneeley@chromium.org>
Commit-Queue: Kyle Charbonneau <kylechar@chromium.org>
Cr-Commit-Position: refs/branch-heads/5563@{#50}
Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
blueboxd pushed a commit that referenced this issue Apr 14, 2023
[M112] Fix tab is closed when back is performed on start surface
0942a4e 
On start surface, getActivityTab still returns a valid tab. If
the tab happens to be closable or navigatable, back press is consumed
to close tab or navigate it back, rather than exiting app.

This CL adds a check to make app exit if back press is performed
on start surface.

(cherry picked from commit 85d08a1)

Bug: 1416719
Change-Id: I84d03ba11ebed34cea2bb7eeb0d01154a8785530
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4262319
Reviewed-by: Donn Denman <donnd@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Commit-Queue: Lijin Shen <lazzzis@google.com>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1109268}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4294386
Cr-Commit-Position: refs/branch-heads/5615@{#50}
Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
blueboxd pushed a commit that referenced this issue May 9, 2023
[Merge M113] Update performance IPH configs to match Finch
31e9d7f 
Changes should reflect the changes being made in cl/519149402

(cherry picked from commit 3c027aa)

Bug: 1427457
Change-Id: I7f100ecb8ce47aeb1bad5c9e04554a610a8481ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4370622
Reviewed-by: Dana Fried <dfried@chromium.org>
Commit-Queue: Alison Gale <agale@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1121967}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4375200
Commit-Queue: Anthony Vallée-Dubois <anthonyvd@chromium.org>
Cr-Commit-Position: refs/branch-heads/5672@{#50}
Cr-Branched-From: 5f2a724-refs/heads/main@{#1121455}
blueboxd pushed a commit that referenced this issue May 27, 2023
Roll ChromeOS Arm AFDO profile from 114-5692.0-1681732680-benchmark-1…
5d938f9 
…14.0.5715.0-r2 to 114-5707.0-1682337030-benchmark-114.0.5735.9-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-arm-chromium-beta
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: Idadece4dec716f051d0cb4c6681d04591c9c5157
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4489843
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5735@{#50}
Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Wowfunhappy @pjpreilly