-
Notifications
You must be signed in to change notification settings - Fork 853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Wait for seek to complete #1712
Conversation
Is it ok to merge? I added quite a lot commits since your review @spydon :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, merge awaaay! 😄
If the AudioPlayer is in a stopped state, the seek function will never complete, and the TimeoutException will fire 30 seconds later. ([ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: TimeoutException after 0:00:30.000000: Future not completed) Any code after the seek will not be executed. From the perspective of a user of the library, the application will hang 30 seconds before registering an unhandled exception. Sample code:
|
Description
Wait for seek to finish by listening to the
AudioEventType.seekComplete
event.Checklist
fix:
,feat:
,refactor:
,docs:
,chore:
,test:
,ci:
etc).///
, where necessary.Related Issues