Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wait for seek to complete #1712

Merged
merged 8 commits into from
Nov 30, 2023
Merged

fix: Wait for seek to complete #1712

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
366fe6d
test: Add pump to receive last position event
Gustl22 Nov 20, 2023
db535e1
fix(linux): block `stop` until seek finished
Gustl22 Nov 28, 2023
b99edd8
test: remove pump
Gustl22 Nov 28, 2023
ce93727
fix: update position, when seek complete
Gustl22 Nov 28, 2023
1d56125
clang-format
Gustl22 Nov 28, 2023
4e851ae
example: remove seeking before playing
Gustl22 Nov 29, 2023
3aa37b8
linux: throw if cannot stop the player
Gustl22 Nov 29, 2023
d075cce
Merge branch 'main' into gustl22/fix-zero-event-linux
Gustl22 Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/audioplayers/example/integration_test/lib_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ void main() async {
}
await tester.pumpLinux();
await player.dispose();
await tester.pumpLinux(); // Needed to receive last position event
final positions = await futurePositions;
printOnFailure('Positions: $positions');
expect(positions, isNot(contains(null)));
Expand Down
Loading