Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrtc: fix crash during client disconnection (#1482) #1501

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Feb 21, 2023

Fixes #1482

OnConnectionStateChange of pion/webrtc is not thread safe. Add a mutex to make it thread safe.

OnConnectionStateChange of pion/webrtc is not thread safe. Add a mutex
to make it thread safe.
@codecov-commenter
Copy link

Codecov Report

Merging #1501 (108c9d2) into main (8ffdd9c) will increase coverage by 0.18%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1501      +/-   ##
==========================================
+ Coverage   65.45%   65.63%   +0.18%     
==========================================
  Files         118      118              
  Lines       12984    12988       +4     
==========================================
+ Hits         8499     8525      +26     
+ Misses       3814     3788      -26     
- Partials      671      675       +4     
Impacted Files Coverage Δ
internal/core/webrtc_conn.go 54.85% <100.00%> (-0.04%) ⬇️
internal/core/source_static.go 75.00% <0.00%> (-4.17%) ⬇️
internal/core/path.go 72.05% <0.00%> (+2.10%) ⬆️
internal/hls/muxer_variant_fmp4_playlist.go 66.26% <0.00%> (+4.86%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aler9 aler9 merged commit 64b8fd3 into main Feb 21, 2023
@aler9 aler9 deleted the webrtc-crash branch February 21, 2023 22:35
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebRTC causes crash on close
2 participants