Skip to content

Commit

Permalink
Merge pull request #84 from blyscuit/bug/#82-log-in-background
Browse files Browse the repository at this point in the history
[#82] [iOS] [UI] Fix: Login screen image not matching device
  • Loading branch information
blyscuit authored Nov 24, 2022
2 parents af1fd82 + c5a845b commit acd0bfc
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 31 deletions.
21 changes: 2 additions & 19 deletions .github/workflows/kmm_review_pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,27 +43,10 @@ jobs:
run: ./gradlew shared:koverXmlReport

- name: Set up Ruby
uses: actions/setup-ruby@v1
uses: ruby/setup-ruby@v1
with:
ruby-version: '2.7'

- name: Cache gems
uses: actions/cache@v2
with:
path: vendor/bundle
key: ${{ runner.os }}-gems-${{ hashFiles('**/Gemfile.lock') }}
restore-keys: |
${{ runner.os }}-gems-
- name: Install Bundle and check environment versions
run: |
echo 'Install Bundle'
bundle config path vendor/bundle
bundle install
echo 'Check environment setup versions'
ruby --version
gem --version
bundler --version
bundler-cache: true

- name: Run Android Danger
env:
Expand Down
21 changes: 12 additions & 9 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ GEM
colored2 (3.1.2)
cork (0.3.0)
colored2 (~> 3.1)
danger (9.0.0)
danger (9.1.0)
claide (~> 1.0)
claide-plugins (>= 0.9.2)
colored2 (~> 3.1)
Expand Down Expand Up @@ -70,19 +70,21 @@ GEM
rexml
kramdown-parser-gfm (1.1.0)
kramdown (~> 2.0)
multipart-post (2.0.0)
multipart-post (2.2.3)
nap (1.1.0)
no_proxy_fix (0.1.2)
nokogiri (1.13.8-x86_64-darwin)
nokogiri (1.13.9-x86_64-darwin)
racc (~> 1.4)
octokit (5.5.0)
nokogiri (1.13.9-x86_64-linux)
racc (~> 1.4)
octokit (5.6.1)
faraday (>= 1, < 3)
sawyer (~> 0.9)
oga (3.4)
ast
ruby-ll (~> 2.1)
open4 (1.3.4)
public_suffix (4.0.7)
public_suffix (5.0.0)
racc (1.6.0)
rchardet (1.8.0)
rexml (3.2.5)
Expand All @@ -93,12 +95,13 @@ GEM
sawyer (0.9.2)
addressable (>= 2.3.5)
faraday (>= 0.17.3, < 3)
terminal-table (1.8.0)
unicode-display_width (~> 1.1, >= 1.1.1)
unicode-display_width (1.8.0)
terminal-table (3.0.2)
unicode-display_width (>= 1.1.1, < 3)
unicode-display_width (2.3.0)

PLATFORMS
x86_64-darwin-21
x86_64-linux

DEPENDENCIES
danger
Expand All @@ -108,4 +111,4 @@ DEPENDENCIES
danger-shroud

BUNDLED WITH
2.3.20
2.3.25
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,14 @@ struct LoginView: View {
.resizable()
.aspectRatio(contentMode: .fill)
.ignoresSafeArea()
.frame(maxWidth: .infinity, maxHeight: .infinity)
.frame(width: geometry.size.width, height: geometry.size.height)

Assets.backgroundBlur
.image
.resizable()
.aspectRatio(contentMode: .fill)
.ignoresSafeArea()
.frame(maxWidth: .infinity, maxHeight: .infinity)
.frame(width: geometry.size.width, height: geometry.size.height)
.opacity(animating ? 1.0 : 0.0)

VStack(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ struct ResetPasswordView: View {
.resizable()
.aspectRatio(contentMode: .fill)
.ignoresSafeArea()
.frame(maxWidth: .infinity, maxHeight: .infinity)
.frame(width: geometry.size.width, height: geometry.size.height)

VStack(
alignment: .center,
Expand Down

0 comments on commit acd0bfc

Please sign in to comment.