[#82] [iOS] [UI] Fix: Login screen image not matching device #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blyscuit
requested review from
suho,
edgarss,
minhnimble and
doannimble
as code owners
blyscuit
force-pushed
the
bug/#82-log-in-background
branch
from
be185d3 to
3fbacc6
Compare
blyscuit
force-pushed
the
bug/#82-log-in-background
branch
from
3fbacc6 to
c5a845b
Compare
🧛 shared Code Coverage:
|
| File | Coverage |
|---|
Modified Files Not Found In Coverage Report:
Gemfile.lock
LoginView.swift
ResetPasswordView.swift
kmm_review_pull_request.yml
Codebase cunningly covered by count Shroud 🧛
Generated by 🚫 Danger
mikepham1011
approved these changes
Nov 22, 2022
minhnimble
requested review from
minhnimble
and removed request for
minhnimble
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened
Fix background image size not matching.
Insight
Use GeometricRenderer size instead of infinite because GeometricRenderer does not know the device size.
Fix CICD failing because ruby library is deprecated.
Update Ruby library.
Proof Of Work
Animation is smooth.
Screen.Recording.2022-11-22.at.12.19.22.mov