[#75] [KMM] [Swift] [Integration] As a user, I can see localized text #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blyscuit
force-pushed
the
feature/#75-kmm-localization
branch
from
a5e1230 to
9447c53
Compare
🧛 shared Code Coverage:
|
| File | Coverage |
|---|---|
MokoLocalize.kt |
100.00% |
Modified Files Not Found In Coverage Report:
Dependency.kt
Info.plist
LoginView.swift
LoginViewModelTest.kt
MokoLocalizeTest.kt
Plugin.kt
ResetPasswordView.swift
StringResource+Localized.swift
Typealiases.swift
Versions.kt
build.gradle.kts
build.gradle.kts
ios_review_pull_request.yml
nimble-jsonapi-kotlin
project.pbxproj
strings.xml
Codebase cunningly covered by count Shroud 🧛
Generated by 🚫 Danger
blyscuit
changed the title
blyscuit
force-pushed
the
feature/#75-kmm-localization
branch
2 times, most recently
from
d57f56c to
bcbc9f0
Compare
blyscuit
requested review from
suho,
edgarss,
minhnimble and
doannimble
as code owners
minhnimble
reviewed
Nov 22, 2022
iosApp/Survey.xcodeproj/xcshareddata/xcschemes/Survey Staging.xcscheme
Outdated
Show resolved
Hide resolved
shared/src/commonMain/kotlin/co/nimblehq/blisskmmic/presentation/helpers/MokoLocalize.kt
Show resolved
Hide resolved
shared/src/commonTest/kotlin/co/nimblehq/blisskmmic/presentation/helpers/MokoLocalizeTest.kt
Outdated
Show resolved
Hide resolved
iosApp/Survey/Sources/Presentation/Modules/Login/LoginView.swift
Outdated
Show resolved
Hide resolved
blyscuit
force-pushed
the
feature/#75-kmm-localization
branch
from
cd1a449 to
62cd127
Compare
|
@blyscuit it looks like we have an CI issue with Setup Ruby step, need to fix it 🛠
|
|
@minhnimble It is fixed here. Waiting for one more approval. |
|
ohh, then should we base this PR on top of the bugfix PR? 🤔 |
blyscuit
force-pushed
the
feature/#75-kmm-localization
branch
from
62cd127 to
ebade6b
Compare
suho
reviewed
Nov 24, 2022
iosApp/Survey/Sources/Supports/Extensions/MokoResources/StringResource+Localized.swift
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened
Sharedmodule.Insight
Proof of Work