[Bug] Fix animations causing tests failures #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blyscuit
changed the title
🧛 shared Code Coverage:
|
| File | Coverage |
|---|
Modified Files Not Found In Coverage Report:
AppDelegate.swift
ArgumentedXCUIApplication.swift
Double+AnimationDuration.swift
FadePaginationView.swift
LaunchArgument.swift
LaunchScreen.storyboard
LoginSpec.swift
LoginView.swift
ResetPasswordSpec.swift
SplashView.swift
SurveyLoadingSpec.swift
SurveySelectionSpec.swift
UITestHelper.swift
project.pbxproj
Codebase cunningly covered by count Shroud 🧛
Generated by 🚫 Danger
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
iosApp/Survey/Sources/Supports/Helpers/UITests/UITests+LaunchArguments.swift
Outdated
Show resolved
Hide resolved
Current coverage for Survey is
|
| Files changed | - | - |
|---|---|---|
| LaunchArgument.swift | 50.00% |
|
| FadePaginationView.swift | 60.51% |
|
| Double+AnimationDuration.swift | 66.67% |
|
| UITestHelper.swift | 90.00% |
✅ |
| LoginView.swift | 95.90% |
✅ |
| SplashView.swift | 100.00% |
✅ |
| AppDelegate.swift | 100.00% |
✅ |
Powered by xcov
Generated by 🚫 Danger
blyscuit
force-pushed
the
bug/fix-screen-animations
branch
from
2694ed7 to
8c571c4
Compare
blyscuit
force-pushed
the
bug/fix-screen-animations
branch
from
8c571c4 to
85c457d
Compare
blyscuit
requested review from
suho,
edgarss,
minhnimble and
doannimble
as code owners
Merged
suho
approved these changes
Dec 7, 2022
minhnimble
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened
UITests is now more consistent.
Insight
fastAnimationspeed up animations in the app.DispatchQueue.mainwithonAppearto fix animation not working properly when view is not fully loaded.Proof Of Work
Passed tests.