Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release - 0.3.0 #88

Merged
merged 36 commits into from
Dec 8, 2022
Merged

Release - 0.3.0 #88

merged 36 commits into from
Dec 8, 2022

Conversation

blyscuit
Copy link
Owner

@blyscuit blyscuit commented Dec 6, 2022 •
edited
Loading

blyscuit and others added 30 commits November 21, 2022 14:27
@blyscuit
[Chore] Update ios to 0.3.0
5077ec0
@blyscuit
Merge pull request #81 from blyscuit/chore/bump-version-0.3.0
af1fd82 
[Chore] Bump version to 0.3.0
@blyscuit
[#82] Fix login background size
f86a3aa
@blyscuit
[#82] Fix ruby action failing
c5a845b
@blyscuit
[#75] Add Moko for localization
0643702
@blyscuit
[#75] Fix naming for PR comments
1ce5bf0
@blyscuit
[#75] Revert scheme naming
ebade6b
@blyscuit
[#75] Use callAsFunction
bde019f
@blyscuit
Merge pull request #84 from blyscuit/bug/#82-log-in-background
acd0bfc 
[#82] [iOS] [UI] Fix: Login screen image not matching device
@blyscuit
Merge pull request #76 from blyscuit/feature/#75-kmm-localization
7b61e00 
[#75] [KMM] [Swift] [Integration] As a user, I can see localized text
@blyscuit
[#54] Add Key-Value saving
12361b4
@blyscuit
[#54] Add token constructor
8ce2872
@blyscuit
[#54] Fix wording comments
49798df
@blyscuit
Merge pull request #77 from blyscuit/feature/#54-datastore-user
bfbf1c7 
[#54] [iOS] [Integration] As a user, my account is persisted in background
@blyscuit
[#13] Add backend reset password
b24b4f1
@blyscuit
[#13] Add reset password viewmodel
d55a2a0 
[#13] Remove unused lint
@blyscuit
[#13] Rename repository for PR comment
bca3d83
@blyscuit
Merge pull request #63 from blyscuit/feature/#13-reset-password-backend
f19f290 
[#13] [KMM] [Backend] As a user, I can reset my password
@blyscuit
[#13] Add backend reset password
c2b90dd
@blyscuit
[#12] Use BaseViewModel
bbb9670
@blyscuit
[#12] Move Mockable import order for PR comment
4c741ff
@blyscuit
[#12] Reindent
a4c5097
@blyscuit
^ This is a combination of 3 commits.
c230d6d 
^ This is the 1st commit message:

[#12] Integrate API with UI

^ The commit message #2 will be skipped:

^ [#12] Use BaseViewModel

^ The commit message #3 will be skipped:

^ [#12] Integrate API with UI
@blyscuit
[#12] Change ui model to contain string resource
acbd671
@blyscuit
[#12] Fix PR comments
25fad98
@blyscuit
[#12] Refactor view datasource
08d3d44
@blyscuit
[#12] Change ui model to contain string resource
5e6a67e
@blyscuit
[#12] Add Data Source tests
94d58fc 
Update ResetPasswordSpec.swift

Update ResetPasswordSpec.swift
@blyscuit
[#12] Add Permission monitor
f969ae1
@blyscuit
[#12] Fix PR comments
b10e311
blyscuit and others added 4 commits December 6, 2022 14:38
@blyscuit
[#12] Fix PR comments
932d3bd
@blyscuit
Merge pull request #64 from blyscuit/feature/#12-reset-password-integ…
4937767 
…rate

[#12] [iOS] [Integrate] [Part1] As a user, I can reset my password
@blyscuit
Merge pull request #85 from blyscuit/feature/#12-reset-password-viewm…
d27367d 
…odel-integrate

[#12] [iOS] [Integrate] [Part2] As a user, I can reset my password
@blyscuit
Merge pull request #86 from blyscuit/feature/#12-unit-test-reset-pass…
0eeaead 
…word

[#12] [iOS] [Integrate] [Part3] As a user, I can reset my password
@blyscuit blyscuit added this to the 0.3.0 milestone Dec 6, 2022
@blyscuit blyscuit self-assigned this Dec 6, 2022
@blyscuit blyscuit marked this pull request as ready for review December 6, 2022 11:35
@github-actions
Copy link

github-actions bot commented Dec 6, 2022 •
edited
Loading

8 Warnings
⚠️ Big PR
⚠️ Please remove period from end of commit subject line.
c230d6d
⚠️ Please separate subject from body with newline.
c230d6d
⚠️ Uh oh! ResetPasswordMeta.kt is under 95% coverage!
⚠️ Uh oh! TokenApiModel.kt is under 95% coverage!
⚠️ Uh oh! TokenDatabaseModel.kt is under 95% coverage!
⚠️ Uh oh! UserTargetType.kt is under 95% coverage!
⚠️ Uh oh! Your project is under 80% coverage!

🧛 shared Code Coverage: 73.78%

Coverage of Modified Files:

File Coverage
AccountRecoveryRepositoryImpl.kt 100.00%
AuthenticationRepositoryImpl.kt 100.00%
DataStore.kt 100.00%
LocalDataSource.kt 100.00%
LogInUseCase.kt 100.00%
MokoLocalize.kt 100.00%
NetworkDataSource.kt 100.00%
NotificationUiModel.kt 100.00%
ResetPasswordMeta.kt 86.61%
ResetPasswordUseCase.kt 100.00%
ResetPasswordViewModel.kt 100.00%
TargetType.kt 100.00%
TokenApiModel.kt 78.07%
TokenDatabaseModel.kt 78.29%
UserTargetType.kt 56.13%

Modified Files Not Found In Coverage Report:

.sourcery.yml
AccountRecoveryRepository.kt
AccountRecoveryRepositoryTest.kt
AnyFlow.kt
ApiServiceTest.kt
AppDelegate.swift
ArgumentedXCUIApplication.swift
AuthenticationRepositoryTest.kt
AutoMockable.stencil
Combine+Collect.swift
DataStoreTest.kt
DatabaseModule.kt
Dependency.kt
Double+AnimationDuration.swift
FadePaginationView.swift
Gemfile.lock
IOSApp.swift
Info.plist
JsonMockEngine.kt
Koin.kt
KoinAndroid.kt
KoinApplication.swift
KoinIOS.kt
LaunchArgument.swift
LaunchScreen.storyboard
LoadingDialog.swift
LocalDataSourceTest.kt
LogInUseCaseTest.kt
LoginSpec.swift
LoginView.swift
LoginViewModelTest.kt
MokoLocalizeTest.kt
NetworkClientTest.kt
NetworkMockModel.kt
NetworkModule.kt
NotificationManager.swift
NotificationManagerSpec.swift
Plugin.kt
RepositoryModule.kt
ResetPassword+DataSource.swift
ResetPasswordJsonResult.kt
ResetPasswordSpec.swift
ResetPasswordUseCaseTest.kt
ResetPasswordView.swift
ResetPasswordViewDataSourceSpec.swift
ResetPasswordViewModelTest.kt
ScreenProtocol+Permission.swift
ScreenProtocol.swift
Shared+AutoMockable.swift
SplashView.swift
Start.kt
StringResource+Localized.swift
Survey Staging.xcscheme
SurveyLoadingSpec.swift
SurveySelectionSpec.swift
TimeInterval+Constants.swift
TokenRepository.kt
Typealiases.swift
UITestHelper.swift
UseCaseModule.kt
Versions.kt
ViewId+General.swift
ViewModelModule.kt
XCTestCase+Publisher.swift
XCUIElement+Label.swift
build.gradle.kts
build.gradle.kts
detekt-config.yml
ios_review_pull_request.yml
kmm_review_pull_request.yml
nimble-jsonapi-kotlin
project.pbxproj
strings.xml

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

@github-actions
Copy link

github-actions bot commented Dec 6, 2022 •
edited
Loading

Current coverage for Survey is 81.32%

Files changed - -
KoinApplication.swift 33.33% 🚫
LaunchArgument.swift 50.00% ⚠️
FadePaginationView.swift 60.51% ⚠️
Double+AnimationDuration.swift 66.67% ⚠️
ResetPassword+DataSource.swift 87.50% ✅
UITestHelper.swift 90.00% ✅
LoginView.swift 95.90% ✅
NotificationManager.swift 98.11% ✅
IOSApp.swift 100.00% ✅
ResetPasswordView.swift 100.00% ✅
LoadingDialog.swift 100.00% ✅
SplashView.swift 100.00% ✅
StringResource+Localized.swift 100.00% ✅
AppDelegate.swift 100.00% ✅

Powered by xcov

Generated by 🚫 Danger

@minhnimble
Copy link
Collaborator

it is looking like we are having some Danger issues that need fixing here @blyscuit 🛠

Repository owner deleted a comment from github-actions bot Dec 7, 2022
Repository owner deleted a comment from github-actions bot Dec 7, 2022
Repository owner deleted a comment from github-actions bot Dec 7, 2022
@blyscuit blyscuit merged commit 89728d9 into main Dec 8, 2022
@blyscuit blyscuit deleted the release/0.3.0 branch December 8, 2022 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doannimble doannimble doannimble approved these changes

@minhnimble minhnimble minhnimble approved these changes

@suho suho Awaiting requested review from suho suho is a code owner

@edgarss edgarss Awaiting requested review from edgarss edgarss is a code owner

Assignees

@blyscuit blyscuit

Labels
type: release
Projects
KMM IC
Status: Done
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@blyscuit @minhnimble @doannimble