Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: data query issues caused by character set replacement #431

Merged
merged 1 commit into from
May 18, 2023
Merged

fix: data query issues caused by character set replacement #431

merged 1 commit into from
May 18, 2023

Conversation

BarryTong65
Copy link
Contributor

@BarryTong65 BarryTong65 commented May 18, 2023 •
edited
Loading

Description

fix: data query issues caused by character set replacement

Rationale

N/A

Example

N/A

Changes

Notable changes:

  • fix the query sql
  • fix potential array index goes out of bounds bug

@BarryTong65 BarryTong65 added the r4r Ready for review label May 18, 2023
sysvm
sysvm approved these changes May 18, 2023
View reviewed changes
Copy link
Collaborator

@sysvm sysvm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sysvm sysvm closed this May 18, 2023
@sysvm sysvm reopened this May 18, 2023
@BarryTong65 BarryTong65 merged commit 302333c into develop May 18, 2023
joeylichang added a commit that referenced this pull request May 26, 2023
@joeylichang @BarryTong65
@constwz @actioncli @will-2012 @fynnss @sysvm @guaguaji010 @annielz @krish-nr @forcodedancing
release: v0.2.1-alpha.1 (#482)
d7752f8 
* fix: data query issues caused by character set replacement (#431)

* fix:blocksyncer statement policy id

* refactor: add gfsp interface, frame, moduler

refactor: add modular entry

refactor: delete redundant code

refactor: add modular options

refactor: tidy entry of gfsp

refactor: delete config dir

feat: add intergrity interface impl

docs: add task readme and annotation

docs: add core modular readme

docs: add piece store docs

docs: add core readme

docs: add error code readme

docs: add bass app readme

refactor: add register modular in main

chore: tidy error code

feat: add manager status

feat: add executor mertic and state

feat: add task info interface for log and debug

feat: add compute func for secondary approval expired height

feat: code tidy for ask approval workflow

feat: code tidy for challenge workflow

feat: code tidy for replicate piece workflow

feat: code tidy for bucket quata workflow

feat: code tidy for upload and download object workflow

feat: code tidy for gfsp config and main entry

feat: code tidy for gfsp client

feat: code tidy for gfsp app dir

feat: code tidy for metrics

feat: code tidy for executor

feat: code tidy for manager

* Release refactor v0.2.1 query cli (#444)

* feat: add query task service and cli command

* fix: add register query service to grpc server

* feat: add p2p ant address config (#446)

* fix: fix check actions (#440)

* fix: fix e2e action

* fix: fix lint action

* fix: fix ut action

---------

Co-authored-by: will-2012 <xibaow2020@qq.com>

* chore: add code format (#443)

* fix: update go.mod (#452)

Co-authored-by: VM <arimas@foxmail.com>

* fix: fix new piece store and spdb (#460)

Co-authored-by: VM <arimas@foxmail.com>

* fix: base app rcmgr span panic (#462)

* chore: refine the refactored branch codes (#451)

* fix: task queue gc delay when call has method (#464)

* refactor:blocksyncer (#450)

* refactor: add block syncer modular
---------

Co-authored-by: constwz <changbohao@gmail.com>

* feat: metadata refactor v0.2.1 (#449)

feat: migrate all metadata methods clients and services

add getObjects handler

fix: runnable retriever

feat: migrate get bucket meta and get object meta

feat: migrate universal endpoint and related methods

feat: migrate switch db

feat: unify naming from retriever to metadata

fix: tests and switch db logic

fix: remove outdated metadata proto

fix: protobuf lint

fix: golangci-lint

fix: db switch and e2e test

fix:typo

fix: e2e script

fix: tests

fix: update switch db logic

fix: naming of methods

fix: restore auth

* chore: add error for cal nil model (#468)

* refactor: update listobjects & blocksyncer modules (#471)

* feat: update listobjects

* fix: add bsdb metadata readme, restore tests, fix get object ue

* fix: adapt juno latest version

* refactor: update go mod

* refactor: update go version to 1.20

* fix: move metadata readme

* fix: bsdb init allow error

* feat: more readme contexts

fix: typo

* fix: update juno version

---------

Co-authored-by: annielz <lmlmzhen@sina.com>
Co-authored-by: krish-nr <krish.z@nodereal.io>

* fix: swtich query error (#476)

* fix: fix sp metrics var name (#474)

Co-authored-by: VM <arimas@foxmail.com>

* refactor: update stop serving module (#473)

* refactor: update stop serving module

* refactor: refactor codes and fix review comments

* fix: fix nonce issue

* chore: add default discontinue bucket keep alive days

---------

Co-authored-by: joeylichang <joeycli0919@gmail.com>

* build: update greenfield chain version (#475)

* chore: refine some codes

* fix: fix error code judgment logic

* chore: refine e2e yml

* build: update greenfield chain dependency

---------

Co-authored-by: will-2012 <xibaow2020@qq.com>

* fix: metrics items name error (#477)

* build: update e2e yml (#479)

Co-authored-by: will-2012 <xibaow2020@qq.com>

* fix: add get public object auth (#481)

* fix: check public object auth

* chore: rm log file

---------

Co-authored-by: Barry <122767193+BarryTong65@users.noreply.github.com>
Co-authored-by: constwz <changbohao30@gmail.com>
Co-authored-by: constwz <122766871+constwz@users.noreply.github.com>
Co-authored-by: actioncli <joeycli0919@qq.com>
Co-authored-by: will-2012 <117156346+will-2012@users.noreply.github.com>
Co-authored-by: will-2012 <xibaow2020@qq.com>
Co-authored-by: Fynn <zcheng1004@gmail.com>
Co-authored-by: VM <112189277+sysvm@users.noreply.github.com>
Co-authored-by: VM <arimas@foxmail.com>
Co-authored-by: constwz <changbohao@gmail.com>
Co-authored-by: Annie <108039750+annielz@users.noreply.github.com>
Co-authored-by: annielz <lmlmzhen@sina.com>
Co-authored-by: krish-nr <krish.z@nodereal.io>
Co-authored-by: forcodedancing <just.haha.it@gmail.com>
@sysvm sysvm deleted the fix-charactersetquery branch May 26, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sysvm sysvm sysvm approved these changes

@ruojunm ruojunm ruojunm approved these changes

@joeylichang joeylichang joeylichang approved these changes

Assignees
No one assigned
Labels
r4r Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BarryTong65 @joeylichang @ruojunm @sysvm