-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: v0.2.1-alpha.1 #482
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix:blocksyncer statement policy id
refactor: add modular entry refactor: delete redundant code refactor: add modular options refactor: tidy entry of gfsp refactor: delete config dir feat: add intergrity interface impl docs: add task readme and annotation docs: add core modular readme docs: add piece store docs docs: add core readme docs: add error code readme docs: add bass app readme refactor: add register modular in main chore: tidy error code feat: add manager status feat: add executor mertic and state feat: add task info interface for log and debug feat: add compute func for secondary approval expired height feat: code tidy for ask approval workflow feat: code tidy for challenge workflow feat: code tidy for replicate piece workflow feat: code tidy for bucket quata workflow feat: code tidy for upload and download object workflow feat: code tidy for gfsp config and main entry feat: code tidy for gfsp client feat: code tidy for gfsp app dir feat: code tidy for metrics feat: code tidy for executor feat: code tidy for manager
* feat: add query task service and cli command * fix: add register query service to grpc server
* fix: fix e2e action * fix: fix lint action * fix: fix ut action --------- Co-authored-by: will-2012 <xibaow2020@qq.com>
Co-authored-by: VM <arimas@foxmail.com>
Co-authored-by: VM <arimas@foxmail.com>
* refactor: add block syncer modular --------- Co-authored-by: constwz <changbohao@gmail.com>
feat: migrate all metadata methods clients and services add getObjects handler fix: runnable retriever feat: migrate get bucket meta and get object meta feat: migrate universal endpoint and related methods feat: migrate switch db feat: unify naming from retriever to metadata fix: tests and switch db logic fix: remove outdated metadata proto fix: protobuf lint fix: golangci-lint fix: db switch and e2e test fix:typo fix: e2e script fix: tests fix: update switch db logic fix: naming of methods fix: restore auth
* feat: update listobjects * fix: add bsdb metadata readme, restore tests, fix get object ue * fix: adapt juno latest version * refactor: update go mod * refactor: update go version to 1.20 * fix: move metadata readme * fix: bsdb init allow error * feat: more readme contexts fix: typo * fix: update juno version --------- Co-authored-by: annielz <lmlmzhen@sina.com> Co-authored-by: krish-nr <krish.z@nodereal.io>
Co-authored-by: VM <arimas@foxmail.com>
* refactor: update stop serving module * refactor: refactor codes and fix review comments * fix: fix nonce issue * chore: add default discontinue bucket keep alive days --------- Co-authored-by: joeylichang <joeycli0919@gmail.com>
* chore: refine some codes * fix: fix error code judgment logic * chore: refine e2e yml * build: update greenfield chain dependency --------- Co-authored-by: will-2012 <xibaow2020@qq.com>
Co-authored-by: will-2012 <xibaow2020@qq.com>
fynnss
reviewed
May 26, 2023
@@ -140,23 +141,25 @@ func (g *GateModular) getObjectHandler(w http.ResponseWriter, r *http.Request) { | |||
} | |||
log.CtxDebugw(reqCtx.Context(), reqCtx.String()) | |||
}() | |||
reqCtx, err = NewRequestContext(r) | |||
reqCtx, reqCtxErr = NewRequestContext(r) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing check reqCtxErr
before use reqCtx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pr releases v0.2.1-alpha.1 version.
Rationale
N/A
Example
N/A
Changes
Notable changes:
N/A