Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: group member key collision issues #410

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

fynnss
Copy link
Contributor

@fynnss fynnss commented Aug 9, 2023

Description

fix group member key collision issues

Rationale

the group id is not fixed length, it may cause the group member key collision.

Example

NA

Changes

Notable changes:

  • NA

x/permission/types/keys.go Outdated Show resolved Hide resolved
return bz
}

return append([]byte{byte(bzLen)}, bz...)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bzLen only one byte?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@fynnss fynnss force-pushed the fix_group_member_key_issue branch from 9f0b70a to 79205a1 Compare August 9, 2023 11:11
@unclezoro unclezoro added this pull request to the merge queue Aug 10, 2023
Merged via the queue into bnb-chain:develop with commit 12d7544 Aug 10, 2023
5 checks passed
@fynnss fynnss deleted the fix_group_member_key_issue branch August 10, 2023 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants