-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve map conformance without losing perf #1445
Conversation
Test262 conformance changes:
Fixed tests (14):
|
Hello @neeldug ! thank you for the contribution and sorry for the delay in the review. It seems this requires a rebase, and it seems to be failing some clippy checks. |
add clear & foreach & delete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more changes and questions.
@jedel1043 Did check and it's unnecessary for delete, and for clear this should work, couldn't find a clean way to replace the reference with a new map so went into OrderedMap to create a method. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nitpicks. We can merge it after this gets fixed :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Improves conformance but avoids following spec directly for performance implications.