-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify object creation with empty
and from_proto_and_data
methods
#1567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test262 conformance changes:
|
jedel1043
force-pushed
the
object_creation
branch
from
September 9, 2021 10:36
6087bbe
to
3da8410
Compare
Holding the ready for review until #1445 merges |
jedel1043
force-pushed
the
object_creation
branch
2 times, most recently
from
October 4, 2021 09:53
9290996
to
b4639cb
Compare
Razican
reviewed
Oct 4, 2021
RageKnify
approved these changes
Oct 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Razican's proposal sounds like a nice QoL improvement.
Razican
approved these changes
Oct 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just needs a rebase :)
jedel1043
force-pushed
the
object_creation
branch
from
October 5, 2021 03:20
9839677
to
201d21f
Compare
jedel1043
force-pushed
the
object_creation
branch
from
October 5, 2021 03:22
201d21f
to
b555c0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another step towards #577.
This Pull Request unifies
JsObject
creation by just having to specify an (optional) prototype and anObjectData
to create a newJsObject
.This refactors patterns like:
into a simpler:
and the expression:
is replaced with:
Also made the
JsObject::new
method private, because we only used it in the latter expression and in a few tests that can perfectly usefrom_proto_and_data