-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial template literal lexer implementation #254
Conversation
I also slipped in a move of self.next() into the match of the lexer itself. In the first commit there is one line related to this:
And the rest is in the second commit. |
So this PR consists of two separate things. 1 is start of implementation of template literal, 2 is putting the self.next inside the match construct. |
@croraf this would need some tests to show it working |
04185b4
to
f588e49
Compare
I added 2 tests. |
@croraf thanks, I’ll have a play with this |
I will soon close this and split in 2 PRs. |
I think the template lexing has been implemented in #455, right? Can we close this? |
I wanted to do a minor refactor of lexer that is present as part of this PR but otherwise the PR is obsolete. |
From this obsolete PR the only thing that remains is the small refactor of the If you like it I will make a separate PR with it? |
All that will soon change with #432. I think it's best to invest on that by doing PRs to that branch :) |
@Razican I thought so. I will close this then. |
Starting to implement. Would like this to be merged now.