Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TemplateLiteral] Basic lexer implementation #455

Merged
merged 2 commits into from
Jun 8, 2020

Conversation

croraf
Copy link
Contributor

@croraf croraf commented Jun 4, 2020

Very basic template literal implementation, of lexer only.

@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #455 into master will increase coverage by 0.10%.
The diff coverage is 85.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #455      +/-   ##
==========================================
+ Coverage   66.83%   66.93%   +0.10%     
==========================================
  Files         127      127              
  Lines        8888     8915      +27     
==========================================
+ Hits         5940     5967      +27     
  Misses       2948     2948              
Impacted Files Coverage Δ
boa/src/syntax/ast/token.rs 45.00% <66.66%> (+0.67%) ⬆️
boa/src/syntax/lexer/mod.rs 56.09% <75.00%> (+1.57%) ⬆️
boa/src/syntax/lexer/tests.rs 99.66% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb2b6f6...f3ec4e2. Read the comment docs.

@jasonwilliams jasonwilliams requested a review from Razican June 5, 2020 13:36
@croraf croraf changed the title [lexer] Basic template literal implementation [TemplateLiteral] Basic lexer implementation Jun 5, 2020
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ok for now, in the future it would be nice to check internal expressions, but not sure if this should be done by the lexer or by the parser.

I added a small comment in order to add some documentation for the token.

boa/src/syntax/ast/token.rs Show resolved Hide resolved
@Razican Razican added this to the v0.9.0 milestone Jun 6, 2020
@Razican Razican added enhancement New feature or request lexer Issues surrounding the lexer labels Jun 6, 2020
@Razican Razican merged commit 863abb3 into boa-dev:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lexer Issues surrounding the lexer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants