-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test + fmt fix #646
Merged
Merged
Test + fmt fix #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lan2u
added
bug
Something isn't working
test
Issues and PRs related to the tests.
labels
Aug 19, 2020
Codecov Report
@@ Coverage Diff @@
## master #646 +/- ##
==========================================
+ Coverage 71.25% 72.50% +1.24%
==========================================
Files 176 179 +3
Lines 11557 13376 +1819
==========================================
+ Hits 8235 9698 +1463
- Misses 3322 3678 +356
Continue to review full report at Codecov.
|
Benchmark for 6e2684eClick to view benchmark
|
HalidOdat
reviewed
Aug 20, 2020
Closed
Benchmark for bde290dClick to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last few PR's introduced a failing test + a rust fmt issue.
Note the 'as u128' is because usize cannot fit the value 100000000000 in all environments.
This should fix both but I'm a little unsure about the test so it would be great if you could check it @HalidOdat ?