Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test #650

Closed
wants to merge 1 commit into from
Closed

Fix test #650

wants to merge 1 commit into from

Conversation

54k1
Copy link
Contributor

@54k1 54k1 commented Aug 20, 2020

This Pull Request fixes the compilation error in exec/tests. Also, sorry about the Rustfmt check failing .. I'll make sure not to do that again.

@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #650 into master will increase coverage by 1.24%.
The diff coverage is 77.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #650      +/-   ##
==========================================
+ Coverage   71.25%   72.50%   +1.24%     
==========================================
  Files         176      179       +3     
  Lines       11557    13376    +1819     
==========================================
+ Hits         8235     9698    +1463     
- Misses       3322     3678     +356     
Impacted Files Coverage Δ
boa/src/builtins/mod.rs 22.58% <0.00%> (-0.76%) ⬇️
boa/src/environment/function_environment_record.rs 27.08% <ø> (ø)
boa/src/environment/global_environment_record.rs 27.95% <0.00%> (ø)
boa/src/syntax/ast/op.rs 9.19% <0.00%> (-0.11%) ⬇️
boa/src/syntax/ast/punctuator.rs 2.10% <0.00%> (-0.03%) ⬇️
boa_cli/src/helper.rs 0.00% <0.00%> (ø)
boa_cli/src/main.rs 33.33% <ø> (+27.45%) ⬆️
boa_wasm/src/lib.rs 0.00% <0.00%> (ø)
boa/src/builtins/error/mod.rs 32.00% <12.50%> (-4.37%) ⬇️
boa/src/builtins/object/iter.rs 14.14% <14.14%> (ø)
... and 94 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13f7374...d58d245. Read the comment docs.

@Razican Razican added the duplicate This issue or pull request already exists label Aug 20, 2020
@Razican
Copy link
Member

Razican commented Aug 20, 2020

This seems to be a duplicate of #646

@Razican Razican closed this Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants