Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt6 tar #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

qt6 tar #16

wants to merge 1 commit into from

Conversation

boehs
Copy link
Owner

@boehs boehs commented Feb 28, 2024

No description provided.

@boehs boehs mentioned this pull request Feb 28, 2024
@alba4k
Copy link

alba4k commented Feb 28, 2024

withouth extra-cmake-modules-git

CMake Error at CMakeLists.txt:16 (find_package):
  Could not find a configuration file for package "ECM" that is compatible
  with requested version "5.240.0".

  The following configuration files were considered but not accepted:

    /usr/share/ECM/cmake/ECMConfig.cmake, version: 5.115.0

with:

CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find KF6 (missing: ColorScheme Config GuiAddons IconThemes
  WindowSystem) (found suitable version "6.0.0", minimum required is
  "5.240.0")
Call Stack (most recent call first):
  /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
  /usr/share/ECM/find-modules/FindKF6.cmake:93 (find_package_handle_standard_args)
  CMakeLists.txt:42 (find_package)

I'm not sure how I should build this?

@boehs
Copy link
Owner Author

boehs commented Feb 29, 2024

Do you have KDE Frameworks 6?

@Jacocococo
Copy link

It looks like this currently fully depends on KF6, which means it won't be able to be used before Plasma 6. (On my Gentoo system that was last updated a week ago I got the first error that alba4k showed even though I can build upstream without any problems)

I also noticed that the same seems to be true for Qt6, which makes me wonder if the theme still works for Qt5 apps or if it defaults back to i.e. Breeze like upstream currently does for Qt6 apps. Have you tried running a Qt5 app? If it doesn't work then this should probably be fixed because there will probably still be a lot apps that will continue to use Qt5 and those apps should still use the theme

This is how Breeze handles both btw

@FantasyPvP
Copy link

i get the following error trying to compile the qt6 branch.
image

I tried adding the lightlystyleconfig.json as it was suggested in #13 but this gave another error
image

from #13 again i downloaded the linked tarball and replaced the contents of /kstyle/config with the contents of the tarball and got this error
image

any ideas on how to get it working? i'm not at all familiar with how cmake works

@boehs
Copy link
Owner Author

boehs commented Mar 1, 2024

@FantasyPvP from the pkgbuild:

build() {
  local _cmake_options=(
    -B build
    -S "$_pkgsrc"
    -DCMAKE_INSTALL_PREFIX='/usr'
    -DCMAKE_INSTALL_LIBDIR='lib'
    -DBUILD_TESTING=OFF
  )

  cmake "${_cmake_options[@]}"
  cmake --build build
}

package() {
  DESTDIR="${pkgdir:?}" cmake --install build
}

waht cmake options are you using? thanks

@FantasyPvP
Copy link

@FantasyPvP from the pkgbuild:

build() {
  local _cmake_options=(
    -B build
    -S "$_pkgsrc"
    -DCMAKE_INSTALL_PREFIX='/usr'
    -DCMAKE_INSTALL_LIBDIR='lib'
    -DBUILD_TESTING=OFF
  )

  cmake "${_cmake_options[@]}"
  cmake --build build
}

package() {
  DESTDIR="${pkgdir:?}" cmake --install build
}

waht cmake options are you using? thanks

i'm using the cmake options given in the build instructions, manually cloning the repo and switching to the qt6 branch

@FantasyPvP
Copy link

@boehs i'm using the exact same cmake options as in the PKGBUILD shown above do i need to be doing something differently?

@OzzyHelix
Copy link

I sort of hope we can get this working because I tried using Plasma 6 with this and it didn't work my hope is this will become compatible with plasma 6 soon

@FantasyPvP
Copy link

I sort of hope we can get this working because I tried using Plasma 6 with this and it didn't work my hope is this will become compatible with plasma 6 soon

If you go to issue #13 there are instructions there that worked for me

@OzzyHelix
Copy link

I sort of hope we can get this working because I tried using Plasma 6 with this and it didn't work my hope is this will become compatible with plasma 6 soon

If you go to issue #13 there are instructions there that worked for me

for my use case it would be better to wait for this pull request to be merged and for the support to be official

@boehs
Copy link
Owner Author

boehs commented Mar 6, 2024

How are you on plasma 6 while waiting for official support? Just trying to understand. This won’t be merged until distros begin officially supporting plasma 6

@FantasyPvP
Copy link

How are you on plasma 6 while waiting for official support? Just trying to understand. This won’t be merged until distros begin officially supporting plasma 6

everything seems to be working great, I've just installed plasma 6 on my main desktop as it just released on the arch stable repos in the last couple of hours and I've had no issues so far. I'm also using lightlyshaders with it

@boehs
Copy link
Owner Author

boehs commented Mar 6, 2024

Sorry I mean the part about “ for my use case it would be better to wait for this pull request to be merged and for the support to be official” from Ozzy because at the time of comment there was no official distribution support for plasma 6 so needing to build this from source is to be expected

@OzzyHelix
Copy link

Sorry I mean the part about “ for my use case it would be better to wait for this pull request to be merged and for the support to be official” from Ozzy because at the time of comment there was no official distribution support for plasma 6 so needing to build this from source is to be expected

plasma 6 was officially released to the main Arch repos today. it left extra-testing on Arch and I compiled Lightly from those instructions it looks fine to me
image

@OzzyHelix
Copy link

I can't tell if there is any glitches with the UI from what I gather it appears to be working fine

@OzzyHelix
Copy link

it would only builds with lightlystyleconfig.json added to the /kstyle/config directory and with CMakeLists.txt, kcm_lightlydecoration.{json,cpp} from the config.tar.gz added to kdecoration/config
and this command used to setup cmake
cmake -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_LIBDIR=lib64 -DBUILD_TESTING=OFF .. from a build directory in the source files

@OzzyHelix
Copy link

if those files are included then it will build just fine and lightly might be compatible with Plasma 6. there are probably issues that I don't know of but so far its working fine for me

@OzzyHelix
Copy link

but yes Plasma 6 is now stable on Arch
https://linuxiac.com/plasma-6-landed-in-archs-stable-repositories/

@boehs
Copy link
Owner Author

boehs commented Mar 7, 2024

I heard yes. This will be done shortly (likely over the weekend)

@ponleou
Copy link

ponleou commented Mar 7, 2024

it would only builds with lightlystyleconfig.json added to the /kstyle/config directory and with CMakeLists.txt, kcm_lightlydecoration.{json,cpp} from the config.tar.gz added to kdecoration/config and this command used to setup cmake cmake -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_LIBDIR=lib64 -DBUILD_TESTING=OFF .. from a build directory in the source files

Tried this, the cmake command worked. However it failed to execute make and getting this error

In file included from /home/Ponleou-KDE/Documents/KDE-MacOS customizer/Lightly/kdecoration/lightlydecoration.cpp:28:
/home/Ponleou-KDE/Documents/KDE-MacOS customizer/Lightly/kdecoration/config/lightlyconfigwidget.h:28:10: fatal error: config/ui_lightlyconfigurationui.h: No such file or directory
   28 | #include "config/ui_lightlyconfigurationui.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [kdecoration/CMakeFiles/lightlydecoration.dir/build.make:119: kdecoration/CMakeFiles/lightlydecoration.dir/lightlydecoration.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:927: kdecoration/CMakeFiles/lightlydecoration.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

@FantasyPvP
Copy link

it would only builds with lightlystyleconfig.json added to the /kstyle/config directory and with CMakeLists.txt, kcm_lightlydecoration.{json,cpp} from the config.tar.gz added to kdecoration/config and this command used to setup cmake cmake -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_LIBDIR=lib64 -DBUILD_TESTING=OFF .. from a build directory in the source files

Tried this, the cmake command worked. However it failed to execute make and getting this error

In file included from /home/Ponleou-KDE/Documents/KDE-MacOS customizer/Lightly/kdecoration/lightlydecoration.cpp:28:
/home/Ponleou-KDE/Documents/KDE-MacOS customizer/Lightly/kdecoration/config/lightlyconfigwidget.h:28:10: fatal error: config/ui_lightlyconfigurationui.h: No such file or directory
   28 | #include "config/ui_lightlyconfigurationui.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [kdecoration/CMakeFiles/lightlydecoration.dir/build.make:119: kdecoration/CMakeFiles/lightlydecoration.dir/lightlydecoration.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:927: kdecoration/CMakeFiles/lightlydecoration.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

I think someone mentioned this in #13, maybe have a look and see if that helps

@ponleou
Copy link

ponleou commented Mar 7, 2024

it would only builds with lightlystyleconfig.json added to the /kstyle/config directory and with CMakeLists.txt, kcm_lightlydecoration.{json,cpp} from the config.tar.gz added to kdecoration/config and this command used to setup cmake cmake -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_LIBDIR=lib64 -DBUILD_TESTING=OFF .. from a build directory in the source files

Tried this, the cmake command worked. However it failed to execute make and getting this error

In file included from /home/Ponleou-KDE/Documents/KDE-MacOS customizer/Lightly/kdecoration/lightlydecoration.cpp:28:
/home/Ponleou-KDE/Documents/KDE-MacOS customizer/Lightly/kdecoration/config/lightlyconfigwidget.h:28:10: fatal error: config/ui_lightlyconfigurationui.h: No such file or directory
   28 | #include "config/ui_lightlyconfigurationui.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [kdecoration/CMakeFiles/lightlydecoration.dir/build.make:119: kdecoration/CMakeFiles/lightlydecoration.dir/lightlydecoration.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:927: kdecoration/CMakeFiles/lightlydecoration.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

I think someone mentioned this in #13, maybe have a look and see if that helps

Read through it, but didn't help me much probably due to my inexperience. However, what I did was execute make inside build/kdecoration/config, afterwards sudo make install worked in build/

cd kdecoration/config
make
cd ../..
make && sudo make install

Now working as expected.

@alba4k
Copy link

alba4k commented Mar 7, 2024

immagine

builds fine on arch after the recent plasma 6 update. Works perfectly fine, and I can keep both the qt5 version and the qt6 version installed.

Talking about this, I think @boehs should consider branching the qt5 version now and keeping it as a "legacy" version, which should still be able to be installed alongside the "mainstream" qt6 one, maybe it could be named lightly-qt5, lightly5 or lightly-legacy

@ukashazia
Copy link

ukashazia commented Mar 7, 2024

immagine

builds fine on arch after the recent plasma 6 update. Works perfectly fine, and I can keep both the qt5 version and the qt6 version installed.

Talking about this, I think @boehs should consider branching the qt5 version now and keeping it as a "legacy" version, which should still be able to be installed alongside the "mainstream" qt6 one, maybe it could be named lightly-qt5, lightly5 or lightly-legacy

can you share the build process

edit: i followed the process described by @OzzyHelix and it now builds

@Kevadroz Kevadroz mentioned this pull request Mar 10, 2024
@OzzyHelix
Copy link

it would only builds with lightlystyleconfig.json added to the /kstyle/config directory and with CMakeLists.txt, kcm_lightlydecoration.{json,cpp} from the config.tar.gz added to kdecoration/config and this command used to setup cmake cmake -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_LIBDIR=lib64 -DBUILD_TESTING=OFF .. from a build directory in the source files

this appears to still be the case when it comes to compiling this I'm not sure why those files aren't included in the qt6 repo or in this pull request but if they existed in the codebase already compiling this for plasma 6 would be easier

@AlphaCraft9658
Copy link

Is anything even happening here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants