Skip to content

Commit

Permalink
fix #2045 - having 2 collection fields in one content type would lead…
Browse files Browse the repository at this point in the history
… to a duplidacate id in the html of the content editor. Fixed by prefixing the id with the collection name.
  • Loading branch information
simongroenewolt authored and bobdenotter committed Oct 25, 2020
1 parent 9406f44 commit e3efd3e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions assets/js/app/editor/Components/Collection.vue
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
<p v-if="templates.length > 1" class="mt-4 mb-1">{{ labels.add_collection_item }}:</p>
<div v-if="templates.length > 1" class="dropdown">
<button
id="dropdownMenuButton"
:id="name + '-dropdownMenuButton'"
:disabled="!allowMore"
class="btn btn-secondary dropdown-toggle"
type="button"
Expand All @@ -51,7 +51,7 @@
>
<i class="fas fa-fw fa-plus"></i> {{ labels.select }}
</button>
<div class="dropdown-menu" aria-labelledby="dropdownMenuButton">
<div class="dropdown-menu" :aria-labelledby="name + '-dropdownMenuButton'">
<a
v-for="template in templates"
:key="template.label"
Expand Down

0 comments on commit e3efd3e

Please sign in to comment.