Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

duplicate id in html for vue Collection dropdown (minor issue!) #2045

Closed
simongroenewolt opened this issue Oct 23, 2020 · 0 comments · Fixed by #2046
Closed

duplicate id in html for vue Collection dropdown (minor issue!) #2045

simongroenewolt opened this issue Oct 23, 2020 · 0 comments · Fixed by #2046

Comments

@simongroenewolt
Copy link
Contributor

Admin content editing:

If you create a contenttype with 2 collection fields, the javascript vue code will create 2 buttons that have the same element id dropdownMenuButton.

This is a minor issue, nothing breaks except for an accessibility aria-labelledby link not being correct. However it is not valid html and maybe someone some day decides to start using that id for other things, and then it will break.

I'll make a PR
simongroenewolt added a commit to simongroenewolt/bolt-core that referenced this issue Oct 23, 2020
@simongroenewolt
fix bolt#2045 - having 2 collection fields in one content type would …
31f5eda 
…lead to a duplidacate id in the html of the content editor. Fixed by prefixing the id with the collection name.
@simongroenewolt simongroenewolt mentioned this issue Oct 23, 2020
Merged
bobdenotter pushed a commit that referenced this issue Oct 25, 2020
@simongroenewolt @bobdenotter
fix #2045 - having 2 collection fields in one content type would lead…
895a407 
… to a duplidacate id in the html of the content editor. Fixed by prefixing the id with the collection name.
bobdenotter pushed a commit that referenced this issue Oct 25, 2020
@simongroenewolt @bobdenotter
fix #2045 - having 2 collection fields in one content type would lead…
e3efd3e 
… to a duplidacate id in the html of the content editor. Fixed by prefixing the id with the collection name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix duplicate html element ids in editor with multiple Collections simongroenewolt/bolt-core
1 participant
@simongroenewolt