Band Component Refactor (API + Demo Updates) #1091
Conversation
| @@ -566,7 +566,7 @@ | |||
|
|
|||
|
|
|||
|
|
|||
| {% embed "@bolt/band--collection.twig" with { | |||
| {% embed "@pl/_band--collection.twig" with { | |||
There was a problem hiding this comment.
Using the private @pl templates doesn't give me a warm fuzzy feeling. This code displays on the docs site, and ideally we don't want any "do as I say, not as I do" examples there.
Is the work to replace the band variations with their source code on all demo pages just too burdensome?
There was a problem hiding this comment.
@remydenton There's a lot of code to change. We can have a task to change them all, instead of holding up the release of this. I agree we should do it sooner rather than later.
On the drupal side, they have their own version of collection band, so this internal template doesn't apply to them anyway. That's also the reason I want us to stop shipping @bolt/band--whatever.twig, these things are just examples, they are not being used. Only the band component twig is used.
There was a problem hiding this comment.
Makes sense. In that case, I'll approve so we can get this out the door. Feel free to create a follow up task if you think it's warranted.
These were not flagged in schema validation. I've created a bug ticket to get that working separately.
|
One additional update I just pushed was removing the demos of deprecated usage, enabling the restrictions in the schema, and cleaning up a few remaining usages of the deprecated version. Make sense? I noticed that schema validation errors in the core of the docs site don't get caught as they should, so I created http://vjira2:8080/browse/BDS-1129 to investigate later. |
…pdates-w-component-refactor # Conflicts: # docs-site/src/pages/pattern-lab/_patterns/02-components/band/_variations/_band--collection.twig # docs-site/src/pages/pattern-lab/_patterns/02-components/band/_variations/_band--feature.twig # docs-site/src/pages/pattern-lab/_patterns/02-components/band/_variations/_band--flag.twig # docs-site/src/pages/pattern-lab/_patterns/02-components/breadcrumb/15-breadcrumb-band-variation.twig # docs-site/src/pages/pattern-lab/_patterns/04-pages/00-full-page-theming/_full-page-theming.twig # docs-site/src/pages/pattern-lab/_patterns/04-pages/05-d8-homepage/00-d8-homepage.twig # docs-site/src/pages/pattern-lab/_patterns/04-pages/05-d8-homepage/05-d8-homepage-japanese.twig # docs-site/src/pages/pattern-lab/_patterns/04-pages/10-d8-product-pages/_product-t3-extra-videos.twig # docs-site/src/pages/pattern-lab/_patterns/04-pages/10-d8-product-pages/_product-t3.twig # docs-site/src/pages/pattern-lab/_patterns/04-pages/10-d8-product-pages/product-landing.twig # docs-site/src/pages/pattern-lab/_patterns/04-pages/10-d8-product-pages/product-t2.twig # docs-site/src/pages/pattern-lab/_patterns/04-pages/10-d8-product-pages/product-t4.twig # docs-site/src/pages/pattern-lab/_patterns/04-pages/20-d8-press-and-media/00-d8-news-landing.twig # docs-site/src/pages/pattern-lab/_patterns/04-pages/35-d8-events/05-event-detail.twig
|
THANKS @mikemai2awesome!! 👏 |
…feature/bds-828-band-refactor--demo-docs-updates-w-component-refactor # Conflicts: # packages/components/bolt-band/band.schema.yml
…feature/bds-828-band-refactor--demo-docs-updates-w-component-refactor
…pdates-w-component-refactor
sghoweri
changed the base branch from
feature/bds-828-band-refactor—component-refactor
to
master
…pdates-w-component-refactor # Conflicts: # docs-site/src/pages/pattern-lab/_patterns/02-components/30-band/10-band-feature-variation.twig # docs-site/src/pages/pattern-lab/_patterns/02-components/30-band/15-band-size-variation.twig # docs-site/src/pages/pattern-lab/_patterns/02-components/30-band/20-band-flag-variation.twig # docs-site/src/pages/pattern-lab/_patterns/02-components/30-band/25-band-theme-variation.twig # docs-site/src/pages/pattern-lab/_patterns/02-components/30-band/30-band-collection-variation.twig # docs-site/src/pages/pattern-lab/_patterns/02-components/30-band/35-band-teaser-variation.twig # docs-site/src/pages/pattern-lab/_patterns/02-components/30-band/40-band-video-background-variation.twig # docs-site/src/pages/pattern-lab/_patterns/02-components/30-band/band-w-pinned-content/60-band-w-pinned-content--via-embed-example.twig # docs-site/src/pages/pattern-lab/_patterns/02-components/30-band/band-w-pinned-content/60-band-w-pinned-content--via-separate-content-and-items.twig # docs-site/src/pages/pattern-lab/_patterns/02-components/30-band/band-w-pinned-content/70-band-w-pinned-content--via-combined-content-and-items-data-example.twig # docs-site/src/pages/pattern-lab/_patterns/02-components/30-band/band-w-pinned-content/_band-for-event-example.twig # docs-site/src/pages/pattern-lab/_patterns/02-components/30-band/band-w-pinned-content/_share-component-for-event-example.twig
@mikemai2awesome - this is a last subset of updates from the full #1010 PR -- specifically focusing on the API-related updates in Pattern Lab + migration of Band "patterns" into Pattern Lab.
Jira
http://vjira2:8080/browse/BDS-828
Summary
Updates demos and docs to match the Band component refactor updates / schema changes.
How to test