Image-related ratio style bug #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…play the correct version of the design system when the version selector loads. changes necessary in order to avoid UX issues with this + any future hotfix releases
This reverts commit 2bae7fe.
…event-autoescaping
…ing the php7.2 install that should no longer be needed
…ependency fix: Replace yarn with npm to avoid yarn dependency
…vent-autoescaping fix: Avoid auto-escaping in image component
This reverts commit 84910f3.
# Conflicts: # CHANGELOG.md # docs-site/CHANGELOG.md # docs-site/package.json # docs-site/src/components/schema-form/CHANGELOG.md # docs-site/src/components/schema-form/package.json # lerna.json # packages/build-tools/CHANGELOG.md # packages/build-tools/package.json # packages/build-tools/plugins/postcss-themify/CHANGELOG.md # packages/build-tools/plugins/postcss-themify/package.json # packages/build-tools/plugins/sass-export-data/CHANGELOG.md # packages/build-tools/plugins/sass-export-data/package.json # packages/build-tools/plugins/sassdoc-webpack-plugin/CHANGELOG.md # packages/build-tools/plugins/sassdoc-webpack-plugin/package.json # packages/components/bolt-action-blocks/CHANGELOG.md # packages/components/bolt-action-blocks/package.json # packages/components/bolt-background-shapes/CHANGELOG.md # packages/components/bolt-background-shapes/package.json # packages/components/bolt-background/CHANGELOG.md # packages/components/bolt-background/package.json # packages/components/bolt-band/CHANGELOG.md # packages/components/bolt-band/package.json # packages/components/bolt-block-list/package.json # packages/components/bolt-blockquote/CHANGELOG.md # packages/components/bolt-blockquote/package.json # packages/components/bolt-breadcrumb/CHANGELOG.md # packages/components/bolt-breadcrumb/package.json # packages/components/bolt-button-group/CHANGELOG.md # packages/components/bolt-button-group/package.json # packages/components/bolt-button/CHANGELOG.md # packages/components/bolt-button/package.json # packages/components/bolt-card/CHANGELOG.md # packages/components/bolt-card/package.json # packages/components/bolt-chip-list/package.json # packages/components/bolt-chip/CHANGELOG.md # packages/components/bolt-chip/package.json # packages/components/bolt-code-snippet/CHANGELOG.md # packages/components/bolt-code-snippet/package.json # packages/components/bolt-copy-to-clipboard/CHANGELOG.md # packages/components/bolt-copy-to-clipboard/package.json # packages/components/bolt-critical-css-vars/CHANGELOG.md # packages/components/bolt-critical-css-vars/package.json # packages/components/bolt-critical-css/CHANGELOG.md # packages/components/bolt-critical-css/package.json # packages/components/bolt-critical-fonts/CHANGELOG.md # packages/components/bolt-critical-fonts/package.json # packages/components/bolt-device-viewer/CHANGELOG.md # packages/components/bolt-device-viewer/package.json # packages/components/bolt-dropdown/CHANGELOG.md # packages/components/bolt-dropdown/package.json # packages/components/bolt-figure/CHANGELOG.md # packages/components/bolt-figure/package.json # packages/components/bolt-form/CHANGELOG.md # packages/components/bolt-form/package.json # packages/components/bolt-grid/CHANGELOG.md # packages/components/bolt-grid/package.json # packages/components/bolt-headline/CHANGELOG.md # packages/components/bolt-headline/package.json # packages/components/bolt-icon/CHANGELOG.md # packages/components/bolt-icon/package.json # packages/components/bolt-icons/CHANGELOG.md # packages/components/bolt-icons/package.json # packages/components/bolt-image/CHANGELOG.md # packages/components/bolt-image/package.json # packages/components/bolt-li/package.json # packages/components/bolt-link/CHANGELOG.md # packages/components/bolt-link/package.json # packages/components/bolt-list/package.json # packages/components/bolt-logo/CHANGELOG.md # packages/components/bolt-logo/package.json # packages/components/bolt-nav-indicator/CHANGELOG.md # packages/components/bolt-nav-indicator/package.json # packages/components/bolt-nav-priority/CHANGELOG.md # packages/components/bolt-nav-priority/package.json # packages/components/bolt-navbar/CHANGELOG.md # packages/components/bolt-navbar/package.json # packages/components/bolt-navlink/CHANGELOG.md # packages/components/bolt-navlink/package.json # packages/components/bolt-ol/package.json # packages/components/bolt-page-footer/CHANGELOG.md # packages/components/bolt-page-footer/package.json # packages/components/bolt-page-header/CHANGELOG.md # packages/components/bolt-page-header/package.json # packages/components/bolt-pagination/CHANGELOG.md # packages/components/bolt-pagination/package.json # packages/components/bolt-placeholder/CHANGELOG.md # packages/components/bolt-placeholder/package.json # packages/components/bolt-ratio/CHANGELOG.md # packages/components/bolt-ratio/package.json # packages/components/bolt-search-filter/CHANGELOG.md # packages/components/bolt-search-filter/package.json # packages/components/bolt-share/CHANGELOG.md # packages/components/bolt-share/package.json # packages/components/bolt-site/CHANGELOG.md # packages/components/bolt-site/package.json # packages/components/bolt-smooth-scroll/CHANGELOG.md # packages/components/bolt-smooth-scroll/package.json # packages/components/bolt-sticky/CHANGELOG.md # packages/components/bolt-sticky/package.json # packages/components/bolt-table/CHANGELOG.md # packages/components/bolt-table/package.json # packages/components/bolt-teaser/CHANGELOG.md # packages/components/bolt-teaser/package.json # packages/components/bolt-text/CHANGELOG.md # packages/components/bolt-text/package.json # packages/components/bolt-tooltip/CHANGELOG.md # packages/components/bolt-tooltip/package.json # packages/components/bolt-ul/package.json # packages/components/bolt-video/CHANGELOG.md # packages/components/bolt-video/package.json # packages/components/lists/bolt-block-list/CHANGELOG.md # packages/components/lists/bolt-chip-list/CHANGELOG.md # packages/components/lists/bolt-li/CHANGELOG.md # packages/components/lists/bolt-list/CHANGELOG.md # packages/components/lists/bolt-ol/CHANGELOG.md # packages/components/lists/bolt-ul/CHANGELOG.md # packages/config-presets/babel-preset-bolt/CHANGELOG.md # packages/config-presets/babel-preset-bolt/package.json # packages/config-presets/config-browserlist/CHANGELOG.md # packages/config-presets/config-browserlist/package.json # packages/config-presets/config-eslint/CHANGELOG.md # packages/config-presets/config-eslint/package.json # packages/config-presets/config-stylelint/CHANGELOG.md # packages/config-presets/config-stylelint/package.json # packages/core-php/CHANGELOG.md # packages/core-php/composer.json # packages/core-php/package.json # packages/core/CHANGELOG.md # packages/core/package.json # packages/drupal-modules/bolt_connect/bolt_connect.info.yml # packages/drupal-modules/bolt_connect/composer.json # packages/drupal-twig-extensions/CHANGELOG.md # packages/drupal-twig-extensions/package.json # packages/global/CHANGELOG.md # packages/global/package.json # packages/twig-renderer/CHANGELOG.md # packages/twig-renderer/package.json # packages/uikit-workshop/CHANGELOG.md # packages/uikit-workshop/package.json
…the casehelper package is installed as expected
…+ fix logic checks to make sure the correct local version is selected
adamszalapski
approved these changes
Apr 18, 2019
mikemai2awesome
approved these changes
Apr 18, 2019
|
@danielamorse head's up -- I'm gonna suggest this get this fix into next v2.4.0 release we publish (another beta or full release -- whichever one we end up with). Updated the base branch this is pointing at to reflect that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
Summary
When JS is turned off, some images overflow their container.
Details
See bug on master with JS off.
We need to add some CSS to the ratio component to fix this.
How to test