[DO NOT MERGE] DS-867: Remove Image Task #2551
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-site copy task to move the images over
colbytcook
changed the title
colbytcook
temporarily deployed
to
feature/DS-86-Remove-Image-Task--branch-preview
colbytcook
changed the title
colbytcook
requested a deployment
to
feature/DS-86-Remove-Image-Task--2058c84--commit-preview
colbytcook
temporarily deployed
to
feature/DS-86-Remove-Image-Task--branch-preview
danielamorse
added a commit
that referenced
this pull request
Oct 4, 2022
danielamorse
changed the title
|
Closing, this work was merged in with #2556 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://pegadigitalit.atlassian.net/browse/DS-867
Summary
Details
Restructured the Doc Site image folder
images/backgrounds/images/content/backgrounds/images/content/academy/images/content/best-of-content/images/content/calculator/images/content/contact/images/content/heroes/images/content/icons/images/content/layout/images/content/logos/480x160images/content/oclp/images/content/portraitsimages/content/profiles/images/content/promosimages/content/screenshotsimages/content/user/images/docsimages/herosimages/logosimages/placeholders/backgrounds/images/shapesMoving forward, we should be utilizing the couple options that are in the
images/placeholders/folder for most Doc Site images. There should be enough images variation to support most of what we need for test images. We can modify or add more moving forward.The content folder should be utilized when we need to build Drupal specific mockups that requires that will be used to build out a design. These images are just for display purposes and should not be shipped to Drupal (Drupal has it's own image management system).
Updated the Documentation pages
Updated the Image Build task
image.bolt.jsonmanifest file (this is not needed anymore).How to test
yarn start,yarn buildandyarn tests:jscommands.-- Note here, I did a very careful review of all the pages so I am fairly certain there are no broken images (no promises though) so i think we would be fine with just focusing on components/elements/pages that we know have a lot of images. For example, review the Background Component, Image Element and Academy pages among others.
Release notes