Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS-867 (Part 1 of 2) Remove Image task #2554

Conversation

danielamorse
Copy link
Collaborator

@danielamorse danielamorse commented Oct 4, 2022

Jira

https://pegadigitalit.atlassian.net/browse/DS-867

Summary

Remove the image task from Bolt.

Details

Part 1 of 2

#2555 is part 2 of 2, where we add the missing images and consolidate the images used in the Pattern Lab demos.

The image task takes a folder of images and creates several resized versions of each and puts them in the www directory. This process is time consuming and relies on Sharp which has been a source of many build errors over the years. It's just not worth it for our docs site.

This PR removes the image task and its dependencies, all references to Bolt image data, and updates snapshots.

There is only one component change, the image component, which removes the reference to Bolt image data. This data is only used in PL and has no effect downstream.

This PR is based on the work done in #2551.

How to test

  • Review code
  • Tests are passing
  • Build runs successfully
    • Note: there will be some missing images until #2555 is merged.

Release notes

  • Removed the bolt img and bolt images tasks. Sites using Bolt should be unaffected.

@github-actions github-actions bot added the type: feature List this PR in the 'Features' section of the release notes. label Oct 4, 2022
@danielamorse danielamorse changed the title DS-867: Remove image task, references to image data, update snapshots DS-867 (Part 1 of 2) Remove Image task Oct 4, 2022
Copy link
Collaborator

@adamszalapski adamszalapski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, working as expected.

@colbytcook colbytcook merged commit 28cfc71 into feature/DS-867-remove-image-task Oct 6, 2022
@colbytcook colbytcook deleted the feature/DS-867-remove-image-task--build branch October 6, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature List this PR in the 'Features' section of the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants