Skip to content

Releases: boltdesignsystem/bolt

v1.8.3

12 Oct 12:37
Compare
Choose a tag to compare

Hotfixes

  • 1.8.3 - Fix z-index regression where device viewer overlaps band background video #864
    • @bolt/components-device-viewer: 1.8.0 => 1.8.3
    • @bolt/website: 1.8.2 => 1.8.3 (private)
    • @bolt/pattern-lab: 1.8.2 => 1.8.3 (private)

Bolt v1.8.2

12 Oct 12:36
Compare
Choose a tag to compare

Enhancements

  • Limit access to bolt_connect admin pages #854

Fixes

  • Fix schema validation for sticky component #853
  • Fix mobile search filter positioning when inside bands #860

Packages Updated

  • @bolt/components-band: 1.8.0 => 1.8.2
  • @bolt/components-sticky: 1.8.0 => 1.8.2
  • @bolt/website: 1.8.1 => 1.8.2 (private)
  • @bolt/pattern-lab: 1.8.1 => 1.8.2 (private)

Bolt v2.0.0-beta.1

12 Oct 12:29
Compare
Choose a tag to compare
Bolt v2.0.0-beta.1 Pre-release
Pre-release

Bolt v2 at a Glance:

Features and Improvements

  • Massive Webpack speed improvements (especially on subsequent saves after the initial bootup)

  • Hot module reloading

  • ~10x faster Sass compiles

  • Brand new theming system building off of the best ideas from the 1st iteration, but with much, much better IE 11 support! #827

  • New @bolt/components-critical-css-vars loader that asynchronously loads up fallback CSS created for browsers without support for CSS Variables

  • Very first component-level end-to-end integration tests added for the Brightcove Video player in Chrome and IE 11 — testing being done via NightwatchJS and Sauce Labs

  • Updated the chip component to use new theming system #839

  • Updated the pagination component to use the new theming system #838

  • Updated the Bolt now.sh deployment script to now point everything at the main boltdesignsystem.com domain moving forward. #841

Deprecated

Removed Deprecated Pegakit Sass

  • Removed font-weight mixin
  • Removed font-size mixin
  • Removed font-family mixin
  • Removed palette mixin
  • Removed clearfix mixin
  • Removed button-color mixin
  • Removed respond-to mixin

Updated docs to reflect deprecation notices

Navbar Gradient and Spacing Options Removed

  • Removed gradient and vspacing config options + demo examples from the current Navbar component (already deprecated and config options already removed internally)

Medium Theme Removed

  • Medium theme option removed from the Band and Card components

Bolt Core Updates

  • Add Pattern Lab demos of using custom element version of button
  • Disables default behavior of opening new browser tab when PL starts
  • Add example to PL of external JS binding to and targeting when a shadow DOM encapsulated button gets clicked, including handling when a component ends up getting re-rendered (which could cause event listeners to get disconnected if not properly handled)
  • Clean up Pattern Lab page examples to not show up in PL view all by default
  • Upgrade our custom Sassdoc plugin to internally cache the JSON data exported by Sassdoc and only write this out to the filesystem when the data changes. This fixes the issue we’ve been having with nearly every single Webpack-watched file change resulting in the same JSON data getting outputted, ultimately causing Pattern Lab to recompile a ton more than it needs to
  • Update Pattern Lab’s watch task in Bolt Build Tools to not immediately recompile Pattern Lab as soon as the the filesystem starts to get watched for changes, saving us from an unnecessary PL recompile when the build tools first boot up
  • Globally renames the HyperHTML-based component base custom element Class we ship in Bolt core from BoltComponent to withHyperHTML to more clearly spell out how that component renderer renders out components + match naming convention already in place with our withPreact custom component renderer
  • Moves our low level helper custom element replace-with-children into a new elements folder that ships with Bolt core and removes it from the Bolt button component
  • Updates all of our component custom element classes to consistently export the main Class; necessarily for extending and building off of any custom elements we ship in Bolt
  • Adds proper slot support to our existing Button component as a reference point to iterate on in other custom elements
  • Updates our button component to fully render itself to the Shadow Dom if supported (vs previously only rendering out its slot to the Shadow Dom); ties in with the external JS binding example in Pattern Lab
  • Cleans up, consolidates button component Twig template
  • Fix button component alignment when embedded inside the card footer
  • Cleans up the existing priority nav component styles; updates to use the new theming system
  • Removes any component level Bolt core dependencies not needed or used in every component; necessary for code splitting and optimizations performed by our build tools
  • Moves to the preact-html dependency over to the code snippet component, the only place it’s currently getting used
  • Add experimental LiHTML component renderer being tested out as a possible lighter weight replacement for both Preact and HyperHTML; no components currently utilize but many of the HyperHTML-related changes prep is for this component renderer consolidation
  • Add example to the text component of switching which tag gets rendered in a HyperHTML-based component, in a much more consolidated syntax
  • Update Babel config dependencies, remove plugins no longer required
  • Fixes several Sassdoc warnings getting thrown

Bolt v1.8.0

12 Oct 12:38
Compare
Choose a tag to compare

What's New

  • bolt-list - A flexible and customizable list component that can generate many different layouts. #842

Enhancements

  • Added support to utility classes on video component #835
  • Implemented all comment documentation for SassDoc #826
  • Allow copy-to-clipboard to work multiple times #850
  • Change icon on copy-to-clipboard when complete to indicate success #850

Fixes

  • Allow videos injected with javascript (e.g. Bound) to work reliably #843
  • Prevent auto-escaping of patterns included within the Share component #846

Deprecations

(none)

Component Version Changes

  • @bolt/components-action-blocks: 1.7.0 => 1.8.0
  • @bolt/components-background-shapes: 1.7.0 => 1.8.0
  • @bolt/components-background: 1.7.0 => 1.8.0
  • @bolt/components-band: 1.7.0 => 1.8.0
  • @bolt/components-block-list: 1.7.0 => 1.8.0
  • @bolt/components-blockquote: 1.7.0 => 1.8.0
  • @bolt/components-breadcrumb: 1.7.0 => 1.8.0
  • @bolt/components-button-group: 1.7.0 => 1.8.0
  • @bolt/components-button: 1.7.0 => 1.8.0
  • @bolt/components-card: 1.7.0 => 1.8.0
  • @bolt/components-chip-list: 1.7.0 => 1.8.0
  • @bolt/components-chip: 1.7.0 => 1.8.0
  • @bolt/components-code-snippet: 1.7.0 => 1.8.0
  • @bolt/components-copy-to-clipboard: 1.7.0 => 1.8.0
  • @bolt/components-critical-fonts: 1.7.0 => 1.8.0
  • @bolt/components-device-viewer: 1.7.0 => 1.8.0
  • @bolt/components-dropdown: 1.7.0 => 1.8.0
  • @bolt/components-figure: 1.7.0 => 1.8.0
  • @bolt/components-form: 1.7.0 => 1.8.0
  • @bolt/components-headline: 1.7.0 => 1.8.0
  • @bolt/components-icon: 1.7.0 => 1.8.0
  • @bolt/components-icons: 1.7.0 => 1.8.0
  • @bolt/components-image: 1.7.0 => 1.8.0
  • @bolt/components-link: 1.7.0 => 1.8.0
  • @bolt/components-list: 0.0.0 => 1.8.0
  • @bolt/components-logo: 1.7.0 => 1.8.0
  • @bolt/components-nav-indicator: 1.7.0 => 1.8.0
  • @bolt/components-nav-priority: 1.7.0 => 1.8.0
  • @bolt/components-navlink: 1.7.0 => 1.8.0
  • @bolt/components-navbar: 1.7.0 => 1.8.0
  • @bolt/components-ordered-list: 1.7.0 => 1.8.0
  • @bolt/components-page-footer: 1.7.0 => 1.8.0 (private)
  • @bolt/components-page-header: 1.7.0 => 1.8.0
  • @bolt/components-pagination: 1.7.0 => 1.8.0
  • @bolt/components-placeholder: 1.7.0 => 1.8.0
  • @bolt/components-search-filter: 1.7.0 => 1.8.0 (private)
  • @bolt/components-share: 1.7.0 => 1.8.0
  • @bolt/components-site: 1.7.0 => 1.8.0
  • @bolt/components-smooth-scroll: 1.7.0 => 1.8.0
  • @bolt/components-sticky: 1.7.0 => 1.8.0
  • @bolt/components-teaser: 1.7.0 => 1.8.0
  • @bolt/components-text: 1.7.0 => 1.8.0 (private)
  • @bolt/components-tooltip: 1.7.0 => 1.8.0
  • @bolt/components-unordered-list: 1.7.0 => 1.8.0
  • @bolt/components-video: 1.7.0 => 1.8.0
  • @bolt/core: 1.7.0 => 1.8.0
  • @bolt/global: 1.7.0 => 1.8.0
  • @bolt/build-tools: 1.7.2 => 1.8.0
  • @bolt/drupal-lab-flash-theme: 1.7.2 => 1.8.0 (private)
  • @bolt/internal-schema-form: 1.7.0 => 1.8.0 (private)
  • @bolt/website: 1.7.2 => 1.8.0 (private)
  • @bolt/pattern-lab: 1.7.2 => 1.8.0 (private)

Hotfixes

1.8.1

Fix copy to clipboard reset in IE 11

Bolt v1.6.0 Released!

04 Jul 19:44
Compare
Choose a tag to compare

Bug Fixes

  • Button Component: Fixed horizontal button alignment options in versions 10 and earlier of Safari and mobile Safari - http://vjira2:8080/browse/BDS-438
  • Dropdown Component: Now renders properly on the server to significantly improve initial rendering + progressively enhanced experience #756
  • Async Font Loader: Fixed async font loader so .woff2 fonts are once again prioritized and loaded first if supported (with .woff files only loaded as a fallback)
  • Redirects / Deploy Issues Resolved: Fixed Now.sh redirect / path resolution issues with the deploy URLs used for viewing / testing the design system staged deploys

Improvements

  • Share Component: Share text is now editable, style improvements: http://vjira2:8080/browse/BDS-366

  • Smooth Scroll Component: Offset behavior can now be set dynamically http://vjira2:8080/browse/WWWD-2288

  • Code Snippet Component: Improved cross browser support + much more consistent styling; JavaScript syntax highlighting support added

  • Navbar Component: Remove navlink focus state when clicking anchor links - http://vjira2:8080/browse/BDS-412

  • Build Tools: Improvements to schema validation coverage + tighter integration with Bolt's build tools BDS-369

  • Bolt Icon Component: Updated the Bolt icon docs to include info + examples on customizing an icon's background color, shape color and background opacity; brand-operations icon added
    pixelsnap 2018-07-05 at 09 19 22

  • Form Input + Input Icon: Icon position is now calculated based on spacing scale; Icon background color now matches its specific states coloring (invalid, disabled, etc.)

  • Language-specific CSS / JS Builds: Bolt's build tools now support compiling language-specific CSS and JS bundles, at the same time! Need to

  • Language-specific CSS / JS Builds: Bolt's build tools now support compiling language-specific CSS and JS bundles -- separate builds are no longer required when testing out the same page with language-optimized CSS and JS builds

Misc

New Components & Features

New Pagination Component Added

pixelsnap 2018-07-05 at 09 24 56

This is a combined effort of @rockymountainhigh1943, @remydenton, and Mike. The following enhancements are added to pagination.

  1. Semantic nav markup
  2. Accessibility support with aria tags and visually hidden micro copy
  3. Circle background (current state) is scalable and not limited to just 3-digit numbers
  4. Alignment can now be controlled by layout objects such as grid, instead of always centering without any opt-out (flexbox handles the alignment now instead of nested inline-blocks)
  5. Bolt spacing variables are used instead of px units, so it scales in relation to all other designs

Breakpoint / Media Query Revamp

So long breakpoint-sass, hello @bolt-mq (based on the awesome sass-mq library from The Guardian)!

  • You may now specify min, max, and range as you please
  • The new @bolt-mq syntax now can handle min-width, max-width, min-max ranges, and custom breakpoint sizes that aren't predefined in the design system.
  • Pattern Lab docs page updated, although Sass-mq's extensive documentation stays relevant for us: https://github.com/sass-mq/sass-mq

@respond-to Sass Mixin Deprecated

  • respond-to is now deprecated (mapped to the new bolt-mq functionality) and will be removed in Bolt v2.0.
  • Using the old @respond-to Sass mixin now throws a deprecation warning when used in Bolt v1.6.0+

Pattern Lab UI Refresh + Massive Speed Improvements

  • Updates Pattern Lab's UI to the latest major version + wires up the code to be locally run in the Bolt repo (prep work for some incredibly exciting design system updates coming soon...)
  • Addresses a number of long running UI bugs / performance issues in Pattern Lab, including now asynchronously loading everything in PL by default
  • Rough 1st pass adding Critical CSS across the board (prep for larger updates in progress). Even with this initial "rough around the edges" work, the docs site homepage is now nearly twice as fast 😄

image

Previous vs Latest Bolt Release Comparison

Mobile 3G:


Desktop:



Package Changes:

 - @bolt/components-action-blocks: 1.5.2 => 1.6.0
 - @bolt/components-background-shapes: 1.5.2 => 1.6.0
 - @bolt/components-background: 1.5.2 => 1.6.0
 - @bolt/components-band: 1.5.2 => 1.6.0
 - @bolt/components-block-list: 1.5.2 => 1.6.0
 - @bolt/components-blockquote: 1.5.2 => 1.6.0
 - @bolt/components-breadcrumb: 1.5.2 => 1.6.0
 - @bolt/components-button-group: 1.5.2 => 1.6.0
 - @bolt/components-button: 1.5.2 => 1.6.0
 - @bolt/components-card: 1.5.2 => 1.6.0
 - @bolt/components-chip-list: 1.5.2 => 1.6.0
 - @bolt/components-chip: 1.5.2 => 1.6.0
 - @bolt/components-code-snippet: 1.5.2 => 1.6.0
 - @bolt/components-copy-to-clipboard: 1.5.2 => 1.6.0
 - @bolt/components-critical-fonts: 1.5.2 => 1.6.0
 - @bolt/components-device-viewer: 1.5.2 => 1.6.0
 - @bolt/components-dropdown: 1.5.2 => 1.6.0
 - @bolt/components-figure: 1.5.2 => 1.6.0
 - @bolt/components-form: 1.5.2 => 1.6.0
 - @bolt/components-headline: 1.5.2 => 1.6.0
 - @bolt/components-icon: 1.5.2 => 1.6.0
 - @bolt/components-icons: 1.5.2 => 1.6.0
 - @bolt/components-image: 1.5.2 => 1.6.0
 - @bolt/components-link: 1.5.2 => 1.6.0
 - @bolt/components-logo: 1.5.2 => 1.6.0
 - @bolt/components-nav-indicator: 1.5.2 => 1.6.0
 - @bolt/components-nav-priority: 1.5.3 => 1.6.0
 - @bolt/components-navlink: 1.5.2 => 1.6.0
 - @bolt/components-navbar: 1.5.2 => 1.6.0
 - @bolt/components-ordered-list: 1.5.2 => 1.6.0
 - @bolt/components-page-footer: 1.5.2 => 1.6.0 (private)
 - @bolt/components-page-header: 1.5.2 => 1.6.0
 - @bolt/components-pagination: 0.0.0 => 1.6.0
 - @bolt/components-placeholder: 1.5.2 => 1.6.0
 - @bolt/components-share: 1.5.2 => 1.6.0
 - @bolt/components-site: 1.5.2 => 1.6.0
 - @bolt/components-smooth-scroll: 1.5.2 => 1.6.0
 - @bolt/components-sticky: 1.5.2 => 1.6.0
 - @bolt/components-teaser: 1.5.2 => 1.6.0
 - @bolt/components-text: 1.5.2 => 1.6.0 (private)
 - @bolt/components-tooltip: 1.5.2 => 1.6.0
 - @bolt/components-unordered-list: 1.5.2 => 1.6.0
 - @bolt/components-video: 1.5.2 => 1.6.0
 - @bolt/uikit-workshop: 1.0.0-alpha.5 => 1.6.0 (private)
 - @bolt/core: 1.5.2 => 1.6.0
 - @bolt/global: 1.5.2 => 1.6.0
 - @bolt/build-tools: 1.5.1 => 1.6.0
 - @bolt/drupal-lab-flash-theme: 1.5.2 => 1.6.0 (private)
 - @bolt/website: 1.5.2 => 1.6.0 (private)
 - @bolt/pattern-lab: 1.5.3 => 1.6.0 (private)

v1.5.0

13 Jun 20:09
Compare
Choose a tag to compare

Bolt Release v1.5.0

A HUGE thanks to the team -- @sghoweri, @theSadowski, @remydenton, @mikemai2awesome, @rockymountainhigh1943, and @joekarasek -- on all the hard work put into getting this latest Bolt release out the door. You guys rock 🎉

Components Additions, Updates, and Removals

  • Bolt Navbar component updated

    • Incorporate recent Bolt Navlink, Bolt Nav Priority, and Bolt Nav Indicator work; Bolt Dropdown component no longer wired up to the Navbar by default as the new Bolt Nav Priority handles the complex interactive behavior natively. The composition of these updates provide an extremely resilient mobile experience and covers breakpoints from the smallest to the largest of viewports.
    • Also updated to support a new center config option
      image
  • Bolt Nav Priority(priority+ nav) component added for handling responsive, resilient site navigation.

image

Heads up! This is used inside the existing Bolt Navbar Component (along with the new Bolt Nav Indicator component) and completely replaces the old @bolt/components-nav component.

Sorry!! Naming things is really hard and we wanted to make sure we named these new components intuitively!

  • Bolt Nav Indicator component added. This handles the active navigation line animation currently used internally by the Bolt Navbar, Bolt Nav Priority and Bolt Navlink components.

image

image

Bug Fixes & Misc Improvements

  • Fixed missing chevron bug / refactored how icons as passed along to components (and how they are opted out of): BDS-334
  • Under the hood improvements to schema validation and syntax; template and schema maintenance BDS-291
  • Fixed button component demos of interactive / pseudo states.
  • Dropdown component demos updated to use the new Block List component added in Bolt v1.4.0.
  • Navbar docs updated to match recent improvements
  • Fixed Block List duplicate rendering bug
  • Twig namespaces globally updated: Bolt-specific Twig templates (@bolt) haven’t changed however we’ve cleaned up our internal Pattern Lab demos and docs to now use the @pl Twig namespace to be super straightforward on what things are available from the design system and which things are being used internally.

Performance

  • Updated the syntax for the validate_data_schema Twig function (used in all Bolt Twig templates with schemas defined) to now use schema data in-memory. This speeds up the compile time of Pattern Lab by over 50% locally and cut down the Travis CI build time by almost 100 seconds! BDS-969
// Updated validate_data_schema syntax:
{% if enable_json_schema_validation %}
	{{ validate_data_schema(bolt.data.components['@bolt-components-button'].schema, _self) | raw }}
 {% endif %}

Docs

Component Version Changes

Changes: 
- @bolt/components-action-blocks: 1.4.0 => 1.5.0 
- @bolt/components-background-shapes: 1.4.1 => 1.5.0 
- @bolt/components-background: 1.4.1 => 1.5.0 
- @bolt/components-band: 1.4.4 => 1.5.0 
- @bolt/components-block-list: 1.4.1 => 1.5.0 
- @bolt/components-blockquote: 1.4.1 => 1.5.0 
- @bolt/components-breadcrumb: 1.4.1 => 1.5.0 
- @bolt/components-button-group: 1.4.0 => 1.5.0 
- @bolt/components-button: 1.4.0 => 1.5.0 
- @bolt/components-card: 1.4.0 => 1.5.0 
- @bolt/components-chip-list: 1.4.1 => 1.5.0 
- @bolt/components-chip: 1.4.1 => 1.5.0 
- @bolt/components-code-snippet: 0.0.0 => 1.5.0 
- @bolt/components-copy-to-clipboard: 1.4.0 => 1.5.0 
- @bolt/components-critical-fonts: 1.4.1 => 1.5.0 
- @bolt/components-device-viewer: 1.4.0 => 1.5.0 
- @bolt/components-dropdown: 1.4.0 => 1.5.0 
- @bolt/components-figure: 1.4.1 => 1.5.0 
- @bolt/components-form: 1.4.0 => 1.5.0 
- @bolt/components-headline: 1.4.1 => 1.5.0 
- @bolt/components-icon: 1.4.0 => 1.5.0 
- @bolt/components-icons: 1.4.0 => 1.5.0 
- @bolt/components-image: 1.4.0 => 1.5.0 
- @bolt/components-link: 1.4.0 => 1.5.0 
- @bolt/components-logo: 1.4.1 => 1.5.0 
- @bolt/components-nav-indicator: 1.5.0-beta.0 => 1.5.0 
- @bolt/components-nav-priority: 1.5.0-beta.0 => 1.5.0 
- @bolt/components-navlink: 1.5.0-beta.0 => 1.5.0 
- @bolt/components-navbar: 1.5.0-beta.0 => 1.5.0
- @bolt/components-nav: removed
- @bolt/components-ordered-list: 1.4.1 => 1.5.0 
- @bolt/components-page-footer: 1.4.0 => 1.5.0 (private) 
- @bolt/components-page-header: 1.4.0 => 1.5.0 
- @bolt/components-placeholder: 1.4.0 => 1.5.0 
- @bolt/components-share: 1.4.1 => 1.5.0 
- @bolt/components-site: 1.4.0 => 1.5.0 
- @bolt/components-smooth-scroll: 1.4.1 => 1.5.0 
- @bolt/components-sticky: 1.4.0 => 1.5.0 
- @bolt/components-teaser: 1.4.1 => 1.5.0 
- @bolt/components-text: 0.0.0 => 1.5.0 (private) 
- @bolt/components-tooltip: 1.4.0 => 1.5.0 
- @bolt/components-unordered-list: 1.4.1 => 1.5.0 
- @bolt/components-video: 1.4.5 => 1.5.0 
- @bolt/core: 1.4.0 => 1.5.0 
- @bolt/global: 1.4.0 => 1.5.0 
- @bolt/build-tools: 1.3.3 => 1.5.0 
- @bolt/babel-preset-bolt: 1.2.1 => 1.5.0 
- @bolt/drupal-lab-flash-theme: 1.4.1 => 1.5.0 (private) 
- @bolt/website: 1.5.0-beta.0 => 1.5.0 (private) 
- @bolt/pattern-lab: 1.5.0-beta.0 => 1.5.0 (private) 
- @bolt/pw-site: 1.4.5 => 1.5.0 (private) 

What’s Next?

  • Theming
  • Enhance share component to support text strings
  • Form bugs
  • Review breakpoints, scope enhancements, begin upgrade
  • Plan WYSIWYG component — In progress

Bolt v1.2.4

27 Apr 19:52
Compare
Choose a tag to compare
  • Fix Navbar underline positioning via #656
  • Fix Navlink active state in IE and Firefox via #657
  • Remove preventDefault link behavior in smoothScroll JS via #658
  • Adds YAML loader to @bolt/build-tools to allow JS components to import .yaml data (ex. pulling in Yaml schemas to enable schema validation on the JavaScript side of things) via #655

Thanks @joekarasek @charginghawk @mikemai2awesome @EvanLovely!

Bolt v1.2.0 Released!

25 Apr 20:06
Compare
Choose a tag to compare

Fixed

  • Fixing Drupal Lab command used to generate content
  • Re-added the "default" u-bolt-margin utility class option which doesn't specify a specific size. Note: this will be removed in Bolt v2.x down the road.

Added

  • Nightwatch.js End To End Integration Testing Coverage added
  • lint-staged to speed up linting process -- only lints what files have changed
  • New <bolt-placeholder> Web Component added
  • Docs demoing the Button and Headline component with icons (and icon positions) added
  • Cleaned up, improved docs and demos for the new Dropdown component, kitchen sink demo added

Updated

  • Updated Share icon SVG used globally
    image
  • The icon.position param has been normalized to now use the before and after config options out of consistency. Places where we had previously been using the left and right config options will still work however these will be removed in Bolt v2.x.
  • Linting Updates: globally cleaned up JavaScript, Yaml, and Sass to use new linting standards now being enforced (quotes, object-shorthand and indent rules)
  • Updated the gray, dark color palette color
  • Updated the Navbar component title to now allow a link to get used
  • Updated the Sticky component to include more robust config options for customization downstream

Misc

  • As part of the Share icon updates, the old share1 and share2 icons have been removed (which are not believed to have been in use currently)
  • Docs site cleanup
  • Removed old / duplicate Dropdown component docs
  • Cleaned up the blue / new color palette color

Thanks so much to @EvanLovely @joekarasek @rockymountainhigh1943 @theSadowski @charginghawk and @mikemai2awesome for their help getting this next release out the door! You guys rock! 🎉

v1.1.12

20 Apr 01:54
Compare
Choose a tag to compare
Adjusting log output

v1.1.11

20 Apr 01:01
Compare
Choose a tag to compare
Tweaking now args